Page MenuHomePhabricator

Fix `arc diff --raw` when run outside a repository
ClosedPublic

Authored by epriestley on May 15 2014, 8:46 PM.
Tags
None
Referenced Files
F15454606: D9142.diff
Sat, Mar 29, 7:18 PM
F15440421: D9142.id21721.diff
Wed, Mar 26, 12:48 PM
F15424287: D9142.diff
Sat, Mar 22, 9:17 PM
F15418595: D9142.id21721.diff
Fri, Mar 21, 12:20 AM
F15394832: D9142.id21711.diff
Sun, Mar 16, 1:16 AM
Unknown Object (File)
Feb 23 2025, 9:36 PM
Unknown Object (File)
Feb 23 2025, 9:31 PM
Unknown Object (File)
Feb 23 2025, 9:10 PM
Subscribers

Details

Summary

Fixes T5071. If you run arc diff --raw from some arbitrary, non-repository directory we incorrectly try to read information out of the working copy. Even if this information is available, arc diff --raw should not assume it's accurate (there's no guarantee the diff comes from the working copy).

Test Plan

Ran arc diff --raw in an arbitrary directory.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix `arc diff --raw` when run outside a repository.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 16 2014, 2:02 AM
epriestley updated this revision to Diff 21721.

Closed by commit rARC75cb3cf35819 (authored by @epriestley).