Page MenuHomePhabricator
Differential D9139

Move Maniphest list rendering to SearchEngine
ClosedPublic
Actions

Authored by epriestley on May 15 2014, 5:51 PM.
Tags
None
Referenced Files
F14068028: D9139.diff
Tue, Nov 19, 6:44 PM
F14055226: D9139.diff
Sat, Nov 16, 9:35 AM
F14042338: D9139.diff
Tue, Nov 12, 2:43 AM
F14040488: D9139.id21726.diff
Mon, Nov 11, 10:34 AM
F14040460: D9139.id21707.diff
Mon, Nov 11, 10:29 AM
F14019492: D9139.diff
Tue, Nov 5, 10:28 PM
F13999421: D9139.id.diff
Thu, Oct 24, 2:38 PM
F13987087: D9139.diff
Oct 21 2024, 7:23 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4986: Implement new Dashboard panel types
Commits
Restricted Diffusion Commit
rPe5e95352c742: Move Maniphest list rendering to SearchEngine
Summary

Ref T4986. Moves Maniphest over. Nothing tricky here, just a complex block of rendering.

Test Plan

Viewed Maniphest list. Created Maniphest panel. Used batch editor, drag-and-drop.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21707.May 15 2014, 5:51 PM
epriestley retitled this revision from to Move Maniphest list rendering to SearchEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4986: Implement new Dashboard panel types.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 15 2014, 5:51 PM
Harbormaster completed remote builds in B490: Diff 21707.May 15 2014, 5:52 PM
btrahan accepted this revision.May 15 2014, 7:51 PM
btrahan edited edge metadata.

yay less code

src/applications/maniphest/controller/ManiphestTaskListController.php
173

nice

This revision is now accepted and ready to land.May 15 2014, 7:51 PM
epriestley closed this revision.May 16 2014, 2:17 AM
epriestley updated this revision to Diff 21726.

Closed by commit rPe5e95352c742 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
26 lines
applications/
maniphest/
controller/
254 lines
query/
37 lines
view/
controller/
ManiphestTaskResultListView.php
ManiphestTaskListController.php
61 lines

Diff 21726

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskListController.php

Loading...
View Options

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

Loading...
View Options

src/applications/maniphest/view/ManiphestTaskResultListView.php

Loading...
Phabricator · Built by Phacility