Page MenuHomePhabricator

Move paste rendering into SearchEngine
ClosedPublic

Authored by epriestley on May 15 2014, 5:23 PM.
Tags
None
Referenced Files
F14065242: D9138.diff
Tue, Nov 19, 3:43 AM
F14051032: D9138.diff
Thu, Nov 14, 10:00 PM
F14040377: D9138.diff
Mon, Nov 11, 9:42 AM
F14034771: D9138.id.diff
Sun, Nov 10, 2:06 AM
F14034770: D9138.id.diff
Sun, Nov 10, 2:06 AM
F14024997: D9138.diff
Thu, Nov 7, 1:53 PM
F14002978: D9138.id21706.diff
Sat, Oct 26, 12:36 AM
F13984517: D9138.diff
Oct 20 2024, 1:58 PM
Subscribers

Details

Summary

Ref T4986. One note:

  • I've disabled syntax highlighting in the previews. When we miss caches this is just way way too slow and has frustrated me several times in the past. The value of syntax highlighting these snippets is not huge. We could maybe ajax this in or use it if we get a cache hit in the future, but just kill it for the moment.
Test Plan

Viewed pastes. Created a paste panel.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Move paste rendering into SearchEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 15 2014, 7:46 PM
epriestley updated this revision to Diff 21725.

Closed by commit rPd653fa13de78 (authored by @epriestley).