Found https://secure.phabricator.com/D4519 but it was horribly out of date, so decided to write a new version.
Kinda clobbered together form that diff and the new version of ArcanistJSHintLinter
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARC6c6035d04b6c: Add Closure linter to arcanist
Tested on personal projects with js files.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- closure
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 480 Build 480: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Minor inlines, but this looks great. Thanks!
- This should also include some unit tests.
src/lint/linter/ArcanistClosureLinter.php | ||
---|---|---|
30 | The regex below hard-codes E:, can this actually emit W: codes? | |
37–46 | Just return 'gjslint', instead of adding new deprecated config options. The bin option in .arclint will let you set this. | |
69–75 | Just remove, flags should cover this now. |
Comment Actions
Thanks!
src/lint/linter/__tests__/ArcanistClosureLinterTestCase.php | ||
---|---|---|
8 ↗ | (On Diff #21702) | This codebase targets PHP 5.2.3 so we can't use the short array syntax. I'll tweak that. |