Add Closure linter to arcanist
ClosedPublic
Actions

Authored by vm on May 15 2014, 10:01 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC6c6035d04b6c: Add Closure linter to arcanist

Summary

Found https://secure.phabricator.com/D4519 but it was horribly out of date, so decided to write a new version.
Kinda clobbered together form that diff and the new version of ArcanistJSHintLinter

Test Plan

Tested on personal projects with js files.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

vm updated this revision to Diff 21692.May 15 2014, 10:01 AM

vm retitled this revision from to Add Closure linter to arcanist.

vm updated this object.

vm edited the test plan for this revision. (Show Details)

vm added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 15 2014, 10:01 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B480: Diff 21692.May 15 2014, 10:02 AM

Minor inlines, but this looks great. Thanks!

This should also include some unit tests.

src/lint/linter/ArcanistClosureLinter.php
31	The regex below hard-codes `E:`, can this actually emit `W:` codes?
38–47	Just return `'gjslint'`, instead of adding new deprecated config options. The `bin` option in `.arclint` will let you set this.
70–76	Just remove, `flags` should cover this now.