Page MenuHomePhabricator
Differential D9121

Notifications - hide header dropdown if app is uninstalled
ClosedPublic
Actions

Authored by btrahan on May 14 2014, 4:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 7:44 AM
Unknown Object (File)
Thu, Dec 19, 3:47 AM
Unknown Object (File)
Wed, Dec 18, 5:08 PM
Unknown Object (File)
Fri, Dec 13, 12:39 PM
Unknown Object (File)
Mon, Dec 9, 1:27 AM
Unknown Object (File)
Sat, Dec 7, 11:00 PM
Unknown Object (File)
Sat, Dec 7, 3:00 AM
Unknown Object (File)
Thu, Dec 5, 11:05 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T5019: Disabling the notification app doesn't remove the notification icon in the toolbar which then is non-functional
Commits
Restricted Diffusion Commit
rP67a5dfa662a8: Notifications - hide header dropdown if app is uninstalled
Summary

Fixes T5019.

Test Plan

uninstalled notifications and dropdown disappeared too

Diff Detail

Repository
rP Phabricator
Branch
T5019
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 462
Build 462: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 21665.May 14 2014, 4:52 PM
btrahan added a task: T5019: Disabling the notification app doesn't remove the notification icon in the toolbar which then is non-functional.
btrahan retitled this revision from to Notifications - hide header dropdown if app is uninstalled.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptMay 14 2014, 4:52 PM
Harbormaster completed remote builds in B462: Diff 21665.May 14 2014, 4:53 PM
epriestley accepted this revision.May 14 2014, 4:56 PM
epriestley edited edge metadata.

(If we have no bubbles at all, it does the right thing?)

src/view/page/menu/PhabricatorMainMenuView.php
368

This should probably be isClassInstalledForViewer().

This revision is now accepted and ready to land.May 14 2014, 4:56 PM
btrahan updated this revision to Diff 21669.May 14 2014, 5:06 PM
btrahan edited edge metadata.
  • s/isInstalled/isInstalledForViewer
  • if (array_filter($menu)) check before adding $menu to alerts

tested with neither conpherence or notifications installed, one or the other, and both

btrahan closed this revision.May 14 2014, 5:07 PM
btrahan updated this revision to Diff 21670.

Closed by commit rP67a5dfa662a8 (authored by @btrahan).

Harbormaster completed remote builds in B465: Diff 21669.May 14 2014, 5:07 PM

Revision Contents
Changeset List

PathSize
src/
view/
page/
menu/
129 lines

Diff 21665

View Options

src/view/page/menu/PhabricatorMainMenuView.php

Loading...
Phabricator · Built by Phacility