Notifications - hide header dropdown if app is uninstalled
ClosedPublic
Actions

Authored by btrahan on May 14 2014, 4:52 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T5019: Disabling the notification app doesn't remove the notification icon in the toolbar which then is non-functional

Commits

Restricted Diffusion Commit
rP67a5dfa662a8: Notifications - hide header dropdown if app is uninstalled

Summary

Fixes T5019.

Test Plan

uninstalled notifications and dropdown disappeared too

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 21665.May 14 2014, 4:52 PM

btrahan added a task: T5019: Disabling the notification app doesn't remove the notification icon in the toolbar which then is non-functional.

btrahan retitled this revision from to Notifications - hide header dropdown if app is uninstalled.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptMay 14 2014, 4:52 PM

Harbormaster completed remote builds in B462: Diff 21665.May 14 2014, 4:53 PM

(If we have no bubbles at all, it does the right thing?)

src/view/page/menu/PhabricatorMainMenuView.php
372	This should probably be `isClassInstalledForViewer()`.

This revision is now accepted and ready to land.May 14 2014, 4:56 PM

s/isInstalled/isInstalledForViewer
if (array_filter($menu)) check before adding $menu to alerts

tested with neither conpherence or notifications installed, one or the other, and both

Closed by commit rP67a5dfa662a8 (authored by @btrahan).

Harbormaster completed remote builds in B465: Diff 21669.May 14 2014, 5:07 PM

Revision Contents
Changeset List

Path

Size

src/

view/

page/

menu/

PhabricatorMainMenuView.php

139 lines

Diff 21670

View Options

src/view/page/menu/PhabricatorMainMenuView.php

Notifications - hide header dropdown if app is uninstalledClosedPublicActions