Differential D9118

Internet Explorer compatibility fixes
ClosedPublic
Actions

Authored by btrahan on May 14 2014, 3:41 PM.

Tags

None

Referenced Files

	F13194402: D9118.diff
	Sun, May 12, 9:32 PM

	F13177498: D9118.diff
	Wed, May 8, 7:45 PM

	Unknown Object (File)
	Mon, Apr 29, 3:33 PM

	Unknown Object (File)
	Fri, Apr 26, 9:42 AM

	Unknown Object (File)
	Wed, Apr 24, 10:26 PM

	Unknown Object (File)
	Mon, Apr 22, 1:37 AM

	Unknown Object (File)
	Apr 11 2024, 8:50 AM

	Unknown Object (File)
	Apr 9 2024, 10:17 PM

Subscribers

Details

Reviewers

epriestley
chad

Maniphest Tasks

T5023: Unable to drag/reorder tasks in any version of IE

Commits

Restricted Diffusion Commit
rP7ab26aef662a: Internet Explorer compatibility fixes

Summary

A few fixes for IE that makes this work in IE9+ and at least you can drag things and have it fail horribly in IE8 now. Ref T5023.

try / catch around getBoundingClientRect because IE throws if the object is not attached to the DOM. The correct value can be inferred in these cases as 0,0
turns out IE has different values for button here (1,2,4) than other browsers. special case this by using the other IE fact that 'which' will be null

Test Plan

dragged and dropped tasks successfully in IE9, IE10, and IE11 on Windows 7. dragged and dropped tasks unsuccessfully in IE8 on Windows 7 - they always "drop" to the 2nd position or so as I think the ondrag code isn't firing properly or something

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 21660.May 14 2014, 3:41 PM

btrahan retitled this revision from to Internet Explorer compatibility fixes.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

btrahan added a task: T5023: Unable to drag/reorder tasks in any version of IE.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptMay 14 2014, 3:41 PM

Harbormaster completed remote builds in B459: Diff 21660.May 14 2014, 3:43 PM

Nice!

This revision is now accepted and ready to land.May 14 2014, 3:45 PM

Closed by commit rP7ab26aef662a (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

52 lines

webroot/

rsrc/

externals/

javelin/

core/

7 lines

lib/

7 lines

Diff 21662

resources/celerity/map.php

Loading...

webroot/rsrc/externals/javelin/core/Event.js

Loading...

webroot/rsrc/externals/javelin/lib/Vector.js

Loading...