Page MenuHomePhabricator

Rename "commitType" to "symbolicType"
ClosedPublic

Authored by epriestley on May 13 2014, 12:25 PM.
Tags
None
Referenced Files
F13267699: D9092.diff
Wed, May 29, 4:01 AM
F13262915: D9092.id.diff
Mon, May 27, 4:58 AM
F13253581: D9092.diff
Sat, May 25, 2:46 AM
F13246492: D9092.diff
Thu, May 23, 10:44 AM
F13242191: D9092.id21600.diff
Thu, May 23, 2:03 AM
F13232643: D9092.diff
Tue, May 21, 1:25 AM
F13211341: D9092.diff
Fri, May 17, 5:41 AM
F13194493: D9092.diff
Sun, May 12, 9:36 PM
Subscribers

Details

Summary

Ref T2683. The old name was a bit confusing because it meant "the type of the thing the symbol represents": a "commit type" should logically always be "commit".

(Currently, this is only used to detect when we're looking at a tag.)

Test Plan

Looked at a tag. Looked at some other non-tag things. Browsed around, grep.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Rename "commitType" to "symbolicType".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 13 2014, 4:14 PM
epriestley updated this revision to Diff 21631.

Closed by commit rP112c9e6b5e08 (authored by @epriestley).