Page MenuHomePhabricator

Rename "commitType" to "symbolicType"
ClosedPublic

Authored by epriestley on May 13 2014, 12:25 PM.
Tags
None
Referenced Files
F18869134: D9092.id21631.diff
Tue, Nov 4, 10:01 AM
F18852796: D9092.id.diff
Fri, Oct 31, 12:01 PM
F18850989: D9092.diff
Thu, Oct 30, 9:05 PM
F18831320: D9092.id21631.diff
Sat, Oct 25, 12:16 PM
F18828087: D9092.id21631.diff
Fri, Oct 24, 2:11 PM
F18821599: D9092.diff
Oct 23 2025, 12:46 AM
F18821463: D9092.id.diff
Oct 22 2025, 11:23 PM
F18813282: D9092.id21631.diff
Oct 20 2025, 3:05 PM
Subscribers

Details

Summary

Ref T2683. The old name was a bit confusing because it meant "the type of the thing the symbol represents": a "commit type" should logically always be "commit".

(Currently, this is only used to detect when we're looking at a tag.)

Test Plan

Looked at a tag. Looked at some other non-tag things. Browsed around, grep.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Rename "commitType" to "symbolicType".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 13 2014, 4:14 PM
epriestley updated this revision to Diff 21631.

Closed by commit rP112c9e6b5e08 (authored by @epriestley).