Fix mobile menus
ClosedPublic
Actions

Authored by chad on May 13 2014, 2:05 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 18, 4:49 AM

	Unknown Object (File)
	Thu, Dec 12, 4:05 AM

	Unknown Object (File)
	Thu, Dec 12, 2:24 AM

	Unknown Object (File)
	Tue, Dec 10, 1:56 AM

	Unknown Object (File)
	Sun, Dec 8, 10:43 PM

	Unknown Object (File)
	Thu, Dec 5, 2:08 AM

	Unknown Object (File)
	Mon, Dec 2, 5:54 PM

	Unknown Object (File)
	Thu, Nov 28, 5:07 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP5b31a17c96e0: Fix mobile menus

Summary

The multiple icons are causing layout issues. This hides the unsused div (the real icon gets appended). We should probably clean this up next redesign.

Test Plan

test mobile layouts in Chrome, test main menu and application menu. Go to Differential, check those menus to.

Diff Detail

Repository

rP Phabricator

Branch

mobile-menu

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 414
Build 414: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 21590.May 13 2014, 2:05 AM

chad retitled this revision from to Fix mobile menus.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptMay 13 2014, 2:05 AM

Harbormaster completed remote builds in B414: Diff 21590.May 13 2014, 2:06 AM

epriestley accepted this revision.May 13 2014, 2:40 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 13 2014, 2:40 AM

Closed by commit rP5b31a17c96e0 (authored by @chad).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

application/

base/

main-menu-view.css

4 lines

Diff 21590

View Options

resources/celerity/map.php