Put an in-request cache in front of APC
ClosedPublic
Actions

Authored by epriestley on May 12 2014, 7:26 PM.

Tags

None

Referenced Files

	F14351939: D9080.diff
	Thu, Dec 19, 11:47 AM

	Unknown Object (File)
	Tue, Dec 17, 11:15 AM

	Unknown Object (File)
	Fri, Dec 13, 8:25 PM

	Unknown Object (File)
	Fri, Dec 13, 7:12 PM

	Unknown Object (File)
	Nov 5 2024, 9:38 PM

	Unknown Object (File)
	Nov 5 2024, 9:33 PM

	Unknown Object (File)
	Nov 5 2024, 5:39 PM

	Unknown Object (File)
	Oct 23 2024, 8:01 AM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPf17099189772: Put an in-request cache in front of APC

Summary

Most requests examine the same buckets, especially the first bucket. Let them just read it out of request cache.

Test Plan

Observed most bucket fetches resolving in <10us instead of <10ms.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21577.May 12 2014, 7:26 PM

epriestley retitled this revision from to Put an in-request cache in front of APC.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 12 2014, 7:26 PM

Harbormaster completed remote builds in B406: Diff 21577.May 12 2014, 7:27 PM

btrahan accepted this revision.May 12 2014, 7:33 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 12 2014, 7:33 PM

Closed by commit rPf17099189772 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

cache/

PhabricatorCaches.php

4 lines

Diff 21579

View Options

src/applications/cache/PhabricatorCaches.php

Put an in-request cache in front of APCClosedPublicActions