Page MenuHomePhabricator
Differential D9073

Make phrasing on "Mark All Read" consistent
ClosedPublic
Actions

Authored by epriestley on May 12 2014, 12:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 1:30 AM
Unknown Object (File)
Thu, Dec 12, 4:05 AM
Unknown Object (File)
Mon, Dec 9, 7:30 AM
Unknown Object (File)
Sun, Dec 8, 1:45 PM
Unknown Object (File)
Tue, Nov 26, 5:19 PM
Unknown Object (File)
Tue, Nov 26, 2:33 AM
Unknown Object (File)
Sat, Nov 23, 2:15 AM
Unknown Object (File)
Sat, Nov 23, 2:15 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T5025: Potentially ambiguous "Clear all notifications" option in Notifications popup
Commits
Restricted Diffusion Commit
rP1687ffcd9e1d: Make phrasing on "Mark All Read" consistent
Summary

Fixes T5025. We label this action in two different ways ("Clear All Notifications", "Mark All Read"). The latter is probably a better description.

Test Plan

looked at the UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21548.May 12 2014, 12:21 PM
epriestley retitled this revision from to Make phrasing on "Mark All Read" consistent.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added a task: T5025: Potentially ambiguous "Clear all notifications" option in Notifications popup.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 12 2014, 12:21 PM
Harbormaster completed remote builds in B396: Diff 21548.May 12 2014, 12:22 PM
chad accepted this revision.May 12 2014, 2:18 PM
chad edited edge metadata.

plustwo

This revision is now accepted and ready to land.May 12 2014, 2:18 PM
epriestley closed this revision.May 12 2014, 2:24 PM
epriestley updated this revision to Diff 21553.

Closed by commit rP1687ffcd9e1d (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
notification/
controller/
2 lines

Diff 21553

View Options

src/applications/notification/controller/PhabricatorNotificationPanelController.php

Loading...
Phabricator · Built by Phacility