Paths

Table of Contentst

Minor tweaks for XHPAST config
ClosedPublic
Actions

Authored by epriestley on May 12 2014, 12:01 PM.

Tags

None

Referenced Files

	F14023447: D9071.diff
	Thu, Nov 7, 2:06 AM

	F13992898: D9071.id21547.diff
	Tue, Oct 22, 7:35 PM

	F13981004: D9071.id21547.diff
	Sat, Oct 19, 1:45 PM

	F13971582: D9071.diff
	Thu, Oct 17, 2:06 PM

	F13971571: D9071.id.diff
	Thu, Oct 17, 2:02 PM

	F13971570: D9071.id21544.diff
	Thu, Oct 17, 2:01 PM

	F13971568: D9071.id21547.diff
	Thu, Oct 17, 1:59 PM

	F13968197: D9071.id21544.diff
	Wed, Oct 16, 7:15 PM

View All Files

Subscribers

epriestley

Details

Reviewers

joshuaspence
btrahan

Maniphest Tasks

Restricted Maniphest Task

Commits

rARC0583b39bb040: Minor tweaks for XHPAST config

Summary

Ref T2039. The type specs are right in theory but not quite correct in practice, since we pass strings in rather than objects.

Test Plan

While tweaking phabricator/, adjusted these to get desirable results.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21544.May 12 2014, 12:01 PM

epriestley retitled this revision from to Minor tweaks for XHPAST config.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, btrahan.

epriestley added a task: Restricted Maniphest Task.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 12 2014, 12:01 PM

Harbormaster completed remote builds in B394: Diff 21544.May 12 2014, 12:02 PM

joshuaspence accepted this revision.May 12 2014, 12:03 PM

joshuaspence edited edge metadata.

This revision is now accepted and ready to land.May 12 2014, 12:03 PM

Closed by commit rARC0583b39bb040 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

12 lines

Diff 21547

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Minor tweaks for XHPAST configClosedPublicActions