Page MenuHomePhabricator
Differential D9067

Remove the `getConfig` and `setConfig` method.
ClosedPublic
Actions

Authored by joshuaspence on May 12 2014, 4:00 AM.
Tags
None
Referenced Files
F14026784: D9067.diff
Fri, Nov 8, 2:20 AM
F14013407: D9067.id21531.diff
Sat, Nov 2, 6:47 AM
F14010957: D9067.diff
Thu, Oct 31, 2:02 PM
F14002295: D9067.id21531.diff
Fri, Oct 25, 5:31 PM
F13995032: D9067.id.diff
Wed, Oct 23, 10:13 AM
F13981368: D9067.diff
Sat, Oct 19, 4:05 PM
Unknown Object (File)
Sep 19 2024, 6:49 AM
Unknown Object (File)
Sep 19 2024, 5:37 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCbe803ce5777c: Remove the `getConfig` and `setConfig` method.
Summary

It seems that there is a lot of overlap between getConfig / setConfig and getLinterConfigurationOptions / setLinterConfigurationValue respectively.

Test Plan

arc lint and arc unit.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 21531.May 12 2014, 4:00 AM
joshuaspence retitled this revision from to Remove the `getConfig` and `setConfig` method..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 12 2014, 4:00 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B387: Diff 21531.May 12 2014, 4:01 AM
epriestley closed this revision.May 12 2014, 11:47 AM
epriestley updated this revision to Diff 21541.
epriestley edited edge metadata.

Closed by commit rARCbe803ce5777c (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
lint/
engine/
2 lines
linter/
22 lines
10 lines
38 lines
__tests__/
5 lines
xhpast/
2 lines

Diff 21541

View Options

src/lint/engine/ComprehensiveLintEngine.php

Loading...
View Options

src/lint/linter/ArcanistLesscLinter.php

Loading...
View Options

src/lint/linter/ArcanistLinter.php

Loading...
View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/switches.lint-test

Loading...
Phabricator · Built by Phacility