Page MenuHomePhabricator

Allow global excludes to be specified in `.arclint`.
ClosedPublic

Authored by joshuaspence on May 11 2014, 12:06 PM.
Tags
None
Referenced Files
F14013408: D9054.id21498.diff
Sat, Nov 2, 6:47 AM
F14005827: D9054.id21498.diff
Sun, Oct 27, 8:24 PM
F14005721: D9054.diff
Sun, Oct 27, 6:16 PM
F13995906: D9054.diff
Wed, Oct 23, 4:33 PM
F13974806: D9054.id21498.diff
Fri, Oct 18, 7:27 AM
F13959130: D9054.diff
Mon, Oct 14, 5:58 PM
Unknown Object (File)
Sep 18 2024, 9:00 PM
Unknown Object (File)
Aug 29 2024, 11:21 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
Restricted Maniphest Task
Commits
rARCc4985ef41556: Allow global excludes to be specified in `.arclint`.
Summary

Currently, paths to be excluded from linting need to be specified for each linter individually. This is a pain for projects that are using even a moderate number of linters and which have common paths which should be excluded from linting completely.

Test Plan

Unfortunately, it's hard to test this sort of stuff. I cloned the arclint-examples repository and tested my changes there,

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Allow global excludes to be specified in `.arclint`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/lint/engine/ArcanistConfigurationDrivenLintEngine.php
28

We added regex to PhutilTypeSpec a while ago -- in the existing case you get a more detailed error from validateRegexps() than checkMap() can raise, but the two errors might have similar usefulness here. I'll just pull this for now and we can evaluate cleaning it up later, I'd like to tune the per-linter errors to make them easier to figure out anyway.

This revision is now accepted and ready to land.May 11 2014, 12:32 PM
epriestley updated this revision to Diff 21500.

Closed by commit rARCc4985ef41556 (authored by @joshuaspence, committed by @epriestley).

joshuaspence added a task: Restricted Maniphest Task.May 11 2014, 9:07 PM