The removes the sprite sheet 'icons' and replaces it with FontAwesome fonts.
Details
- Reviewers
epriestley btrahan - Commits
- Restricted Diffusion Commit
rPb2f3001ec4be: Replace Sprite-Icons with FontAwesome
- Grep for SPRITE_ICONS and replace
- Grep for sprite-icons and replace
- Grep for PhabricatorActionList and choose all new icons
- Grep for Crumbs and fix icons
- Test/Replace PHUIList Icon support
- Test/Replace ObjectList Icon support (foot, epoch, etc)
- Browse as many pages as I could get to
- Remove sprite-icons and move remarkup to own sheet
- Review this diff in Differential
Diff Detail
- Repository
- rP Phabricator
- Branch
- fa-policy
- Lint
Lint Skipped - Unit
Tests Passed - Build Status
Buildable 361 Build 361: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
I'd say I'd likely got 98-100% of them. Will do another grep-pass in the am. If something was missed it'd just be a fallback of no icon. I wanted to get this all in one diff in case we needed to revert.
I ran this through Safair, Chrome, FF, and IE 8-11. No issues noted.
Two small things:
- I'd expect these disabled icons to render in grey, but they're rendering in black:
- The fa-thumbs-up icon has a certain doughiness to it -- maybe use fa-tumbs-o-up, fa-trophy or put it on the "eventual dough removal" list?
These generally look great to me, though.
OK, FYI I updated and landed this. I was not able to lint it (I gave up after it said linting... for 20 minutes).
We made a bunch of lint changes last night so we might have broken something -- if you haven't yet, try updating libphutil/ and arcanist/, and yell if it happens again? Hopefully that'll either fix it or I'll hit it before you do and have a fix by then.
Happy anniversary!
I run my update script every morning and before any arc land. Just curious what it's doing given 300 file changes.
Hrrm, not sure. It ran OK for me locally -- took a little while (57 seconds) but nothing too bad.
Thanks, will see if it continues to be an issue.
Stef is sadly very sick today, so I'm trying to keep things low key in the house.