Page MenuHomePhabricator

Replace Sprite-Icons with FontAwesome
ClosedPublic

Authored by chad on May 11 2014, 5:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 7:51 AM
Unknown Object (File)
Wed, Apr 24, 10:38 PM
Unknown Object (File)
Sun, Apr 14, 9:46 PM
Unknown Object (File)
Tue, Apr 2, 1:45 AM
Unknown Object (File)
Thu, Mar 28, 6:19 AM
Unknown Object (File)
Mar 10 2024, 10:29 AM
Unknown Object (File)
Feb 26 2024, 11:09 PM
Unknown Object (File)
Feb 21 2024, 3:49 AM

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rPb2f3001ec4be: Replace Sprite-Icons with FontAwesome
Summary

The removes the sprite sheet 'icons' and replaces it with FontAwesome fonts.

Test Plan
  • Grep for SPRITE_ICONS and replace
  • Grep for sprite-icons and replace
  • Grep for PhabricatorActionList and choose all new icons
  • Grep for Crumbs and fix icons
  • Test/Replace PHUIList Icon support
  • Test/Replace ObjectList Icon support (foot, epoch, etc)
  • Browse as many pages as I could get to
  • Remove sprite-icons and move remarkup to own sheet
  • Review this diff in Differential

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad retitled this revision from to Replace Sprite-Icons with FontAwesome.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
  • Fix some typos, better consistent icons

I'd say I'd likely got 98-100% of them. Will do another grep-pass in the am. If something was missed it'd just be a fallback of no icon. I wanted to get this all in one diff in case we needed to revert.

I ran this through Safair, Chrome, FF, and IE 8-11. No issues noted.

epriestley edited edge metadata.

Two small things:

  • I'd expect these disabled icons to render in grey, but they're rendering in black:

Screen_Shot_2014-05-12_at_8.15.12_AM.png (168×378 px, 10 KB)

  • The fa-thumbs-up icon has a certain doughiness to it -- maybe use fa-tumbs-o-up, fa-trophy or put it on the "eventual dough removal" list?

These generally look great to me, though.

This revision is now accepted and ready to land.May 12 2014, 3:21 PM
chad updated this revision to Diff 21562.

Closed by commit rPb2f3001ec4be (authored by @chad).

OK, FYI I updated and landed this. I was not able to lint it (I gave up after it said linting... for 20 minutes).

We made a bunch of lint changes last night so we might have broken something -- if you haven't yet, try updating libphutil/ and arcanist/, and yell if it happens again? Hopefully that'll either fix it or I'll hit it before you do and have a fix by then.

Happy anniversary!

I run my update script every morning and before any arc land. Just curious what it's doing given 300 file changes.

Hrrm, not sure. It ran OK for me locally -- took a little while (57 seconds) but nothing too bad.

You can use arc lint --trace to see exactly what's up.

Thanks, will see if it continues to be an issue.

Stef is sadly very sick today, so I'm trying to keep things low key in the house.