Page MenuHomePhabricator

Use bracket-free, human-readable query URIs everywhere
ClosedPublic

Authored by epriestley on May 10 2014, 3:13 PM.
Tags
None
Referenced Files
F14351721: D9042.diff
Thu, Dec 19, 9:47 AM
Unknown Object (File)
Tue, Dec 17, 8:45 AM
Unknown Object (File)
Mon, Dec 16, 5:44 PM
Unknown Object (File)
Fri, Dec 13, 12:55 AM
Unknown Object (File)
Thu, Dec 12, 6:21 AM
Unknown Object (File)
Sun, Dec 1, 2:51 PM
Unknown Object (File)
Mon, Nov 25, 12:53 AM
Unknown Object (File)
Sun, Nov 24, 9:40 PM
Subscribers
Tokens
"Love" token, awarded by qgil.

Details

Summary

See http://fab.wmflabs.org/T88. While this issue is on MW's side, these links are kind of ugly and have more readable alternate forms now. Update them to use proper modern forms.

Test Plan

See inlines.

Diff Detail

Repository
rP Phabricator
Branch
blinks
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 345
Build 345: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Use bracket-free, human-readable query URIs everywhere.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
src/applications/differential/event/DifferentialActionMenuEventListener.php
36–40

Clicked the link on my profile. We don't need to make this a form anymore, I think that was a leftover from a very long time ago before ApplicationSearch.

src/applications/home/controller/PhabricatorHomeMainController.php
151–154

This was buggy anyway on installs with more than "open" status option, since statuses[]=a,b is not a valid construction.

199

This should be urisprintf(), I'll fix that locally...

200

Same as above, buggy with more than one open status.

src/applications/maniphest/event/ManiphestActionMenuEventListener.php
47

This has no callsite, and wasn't updated for configurable statuses.

btrahan edited edge metadata.

Cool beans. I don't think I've seen urisprintf before...!

This revision is now accepted and ready to land.May 10 2014, 5:04 PM
epriestley updated this revision to Diff 21476.

Closed by commit rPb64415c9b138 (authored by @epriestley).