Paths

Table of Contentst

Differential D9033

Modernize `ArcanistCpplintLinter`.
ClosedPublic
Actions

Authored by joshuaspence on May 10 2014, 1:55 AM.

Tags

None

Referenced Files

	F14753080: D9033.id21457.diff
	Tue, Jan 21, 3:01 PM

	Unknown Object (File)
	Sat, Jan 18, 2:02 AM

	Unknown Object (File)
	Sat, Jan 18, 12:24 AM

	Unknown Object (File)
	Sat, Jan 4, 9:09 AM

	Unknown Object (File)
	Mon, Dec 30, 12:37 AM

	Unknown Object (File)
	Dec 20 2024, 4:17 PM

	Unknown Object (File)
	Dec 17 2024, 6:22 AM

	Unknown Object (File)
	Dec 14 2024, 4:28 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

Restricted Maniphest Task

Commits

rARC4a1b8a3299e8: Modernize `ArcanistCpplintLinter`.

Summary

Convert the cpplint.py wrapper linter to ArcanistExternalLinter. This is in preparation for T2039.

Test Plan

arc unit.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 21457.May 10 2014, 1:55 AM

joshuaspence retitled this revision from to Modernize `ArcanistCpplintLinter`..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 10 2014, 1:55 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B335: Diff 21457.May 10 2014, 1:56 AM

joshuaspence added a task: Restricted Maniphest Task.May 10 2014, 1:56 AM

One tiny inline. If the stdin thing seems reasonable feel free to glom it onto this.

src/lint/linter/ArcanistCpplintLinter.php
30	"JSHint" should be "cpplint.py" or similar.
42–45	Not precisely related, but maybe we should make this the default implementation for simplicity so we don't need as many copies of this in subclasses?

This revision now requires changes to proceed.May 10 2014, 2:25 AM

joshuaspence added inline comments.May 10 2014, 3:51 AM

src/lint/linter/ArcanistCpplintLinter.php
42–45	I agree. I'll submit this separately.

s/JSHint/cpplint.py/

Harbormaster completed remote builds in B336: Diff 21458.May 10 2014, 3:53 AM

Thanks!

This revision is now accepted and ready to land.May 10 2014, 8:32 AM

Closed by commit rARC4a1b8a3299e8 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

lint/

linter/

ArcanistCpplintLinter.php

95 lines

Diff 21466

src/__phutil_library_map__.php

Loading...

src/lint/linter/ArcanistCpplintLinter.php

Loading...