Page MenuHomePhabricator

Add 'repositoryPHID' to 'differential.createrawdiff'
ClosedPublic

Authored by epriestley on May 9 2014, 2:40 PM.
Tags
None
Referenced Files
F13242091: D9023.id.diff
Thu, May 23, 1:53 AM
F13240734: D9023.id21456.diff
Wed, May 22, 4:09 PM
F13237077: D9023.id.diff
Tue, May 21, 12:23 PM
Unknown Object (File)
Apr 3 2024, 2:55 PM
Unknown Object (File)
Mar 5 2024, 4:31 AM
Unknown Object (File)
Feb 22 2024, 2:06 PM
Unknown Object (File)
Feb 16 2024, 1:30 AM
Unknown Object (File)
Feb 10 2024, 10:05 PM

Details

Summary

See https://github.com/facebook/phabricator/issues/596

Broadly, Facebook would like to bring Pull Requests from GitHub into Phabricator.

In the long term we can do this properly via Doorkeeper/Nuance, but that's probably a ways off. This seems like a reasonable low-budget compromise for now.

I'm a little hesitant to add a ton of parameters to this call, but repositoryPHID seems pretty reasonable, and is notable because it also controls default policies.

Test Plan
  • Created a diff with no repositoryPHID.
  • Created a diff with a repositoryPHID.
    • Verified it carried over when the diff was used to create a revision.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Add 'repositoryPHID' to 'differential.createrawdiff'.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 9 2014, 6:49 PM
epriestley updated this revision to Diff 21456.

Closed by commit rP997c8591b27f (authored by @epriestley).