Paths

Table of Contentst

Differential D9023

Add 'repositoryPHID' to 'differential.createrawdiff'
ClosedPublic
Actions

Authored by epriestley on May 9 2014, 2:40 PM.

Tags

None

Referenced Files

	F15481138: D9023.id21436.diff
	Tue, Apr 8, 6:27 PM

	F15475508: D9023.id.diff
	Sun, Apr 6, 8:03 PM

	F15473059: D9023.diff
	Sat, Apr 5, 7:22 PM

	F15443708: D9023.diff
	Thu, Mar 27, 5:47 AM

	F15411715: D9023.id.diff
	Wed, Mar 19, 9:33 AM

	F15407874: D9023.id21456.diff
	Tue, Mar 18, 7:59 PM

	F15394180: D9023.id.diff
	Sat, Mar 15, 11:21 PM

	Unknown Object (File)
	Mar 2 2025, 8:02 PM

Subscribers

Details

Reviewers

Commits

Restricted Diffusion Commit
rP997c8591b27f: Add 'repositoryPHID' to 'differential.createrawdiff'

Summary

See https://github.com/facebook/phabricator/issues/596

Broadly, Facebook would like to bring Pull Requests from GitHub into Phabricator.

In the long term we can do this properly via Doorkeeper/Nuance, but that's probably a ways off. This seems like a reasonable low-budget compromise for now.

I'm a little hesitant to add a ton of parameters to this call, but repositoryPHID seems pretty reasonable, and is notable because it also controls default policies.

Test Plan

Created a diff with no repositoryPHID.
Created a diff with a repositoryPHID.
- Verified it carried over when the diff was used to create a revision.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21436.May 9 2014, 2:40 PM

epriestley retitled this revision from to Add 'repositoryPHID' to 'differential.createrawdiff'.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 9 2014, 2:40 PM

Harbormaster completed remote builds in B321: Diff 21436.May 9 2014, 2:41 PM

jamesgpearce added a subscriber: ptarjan.May 9 2014, 4:26 PM

jamesgpearce added a subscriber: jamesgpearce.

btrahan accepted this revision.May 9 2014, 6:49 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 9 2014, 6:49 PM

Closed by commit rP997c8591b27f (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

conduit/

ConduitAPI_differential_createrawdiff_Method.php

25 lines

Diff 21456

src/applications/differential/conduit/ConduitAPI_differential_createrawdiff_Method.php

Loading...