Paths

Table of Contentst

Differential D9023

Add 'repositoryPHID' to 'differential.createrawdiff'
ClosedPublic
Actions

Authored by epriestley on May 9 2014, 2:40 PM.

Tags

None

Referenced Files

	F14834157: D9023.id.diff
	Thu, Jan 30, 2:17 PM

	Unknown Object (File)
	Mon, Jan 27, 2:33 AM

	Unknown Object (File)
	Sun, Jan 26, 5:43 PM

	Unknown Object (File)
	Sun, Jan 26, 5:43 PM

	Unknown Object (File)
	Sun, Jan 26, 5:42 PM

	Unknown Object (File)
	Sun, Jan 26, 5:28 PM

	Unknown Object (File)
	Thu, Jan 23, 5:48 PM

	Unknown Object (File)
	Dec 31 2024, 12:41 PM

Subscribers

Details

Reviewers

Commits

Restricted Diffusion Commit
rP997c8591b27f: Add 'repositoryPHID' to 'differential.createrawdiff'

Summary

See https://github.com/facebook/phabricator/issues/596

Broadly, Facebook would like to bring Pull Requests from GitHub into Phabricator.

In the long term we can do this properly via Doorkeeper/Nuance, but that's probably a ways off. This seems like a reasonable low-budget compromise for now.

I'm a little hesitant to add a ton of parameters to this call, but repositoryPHID seems pretty reasonable, and is notable because it also controls default policies.

Test Plan

Created a diff with no repositoryPHID.
Created a diff with a repositoryPHID.
- Verified it carried over when the diff was used to create a revision.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21436.May 9 2014, 2:40 PM

epriestley retitled this revision from to Add 'repositoryPHID' to 'differential.createrawdiff'.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 9 2014, 2:40 PM

Harbormaster completed remote builds in B321: Diff 21436.May 9 2014, 2:41 PM

jamesgpearce added a subscriber: ptarjan.May 9 2014, 4:26 PM

jamesgpearce added a subscriber: jamesgpearce.

btrahan accepted this revision.May 9 2014, 6:49 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 9 2014, 6:49 PM

Closed by commit rP997c8591b27f (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

conduit/

ConduitAPI_differential_createrawdiff_Method.php

25 lines

Diff 21456

src/applications/differential/conduit/ConduitAPI_differential_createrawdiff_Method.php

Loading...