Page MenuHomePhabricator

Remove `debug` key from `.arclint` file format.
ClosedPublic

Authored by joshuaspence on May 9 2014, 12:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 6:21 AM
Unknown Object (File)
Thu, Nov 28, 6:33 PM
Unknown Object (File)
Thu, Nov 28, 6:33 PM
Unknown Object (File)
Thu, Nov 28, 6:33 PM
Unknown Object (File)
Thu, Nov 28, 6:15 PM
Unknown Object (File)
Mon, Nov 25, 4:34 PM
Unknown Object (File)
Nov 19 2024, 6:17 PM
Unknown Object (File)
Nov 17 2024, 12:20 AM
Subscribers

Details

Summary

Having a debug key in the .arclint file format doesn't seem right. Instead, it would be better to just use a PhutilConsole and the writeLog method so that "debug" messages are output when using arc --trace.

Test Plan

Ran arc lint --trace in a repository using .arclint.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Remove `debug` key from `.arclint` file format..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

Three weak arguments for this are:

  • This output is potentially much more verbose than most --trace output, and separating it might be useful.
  • If arc is running via Harbormaster in the future, it may be difficult to add --trace.
  • Having some key other than linters at top level might reduce confusion.

These are all pretty tenuous, though, and this is simpler and we can switch back if any of them prove compelling.

This revision is now accepted and ready to land.May 9 2014, 12:59 PM
epriestley updated this revision to Diff 21433.

Closed by commit rARC4298b4ea8b76 (authored by @joshuaspence, committed by @epriestley).