Page MenuHomePhabricator
Differential D9011

Move audit rendering into SearchEngine
ClosedPublic
Actions

Authored by epriestley on May 8 2014, 3:51 PM.
Tags
None
Referenced Files
F14728748: D9011.diff
Sat, Jan 18, 5:53 AM
F14712409: D9011.id21400.diff
Fri, Jan 17, 3:47 PM
Unknown Object (File)
Fri, Jan 17, 2:18 AM
Unknown Object (File)
Sun, Jan 12, 5:53 PM
Unknown Object (File)
Sat, Jan 4, 3:05 AM
Unknown Object (File)
Tue, Dec 31, 2:44 PM
Unknown Object (File)
Mon, Dec 23, 8:11 AM
Unknown Object (File)
Mon, Dec 23, 8:11 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4986: Implement new Dashboard panel types
Commits
Restricted Diffusion Commit
rPc72b753e5407: Move audit rendering into SearchEngine
Summary

Ref T4986. Updates audit.

Slightly tweaks on method visibility.

Just used a HandleQuery since we have to rebuild the whole view thing otherwise; this is an unusual case.

Test Plan
  • Checked Audit.
  • Checked Feed.
  • Checked Slowvote.

Screen_Shot_2014-05-08_at_8.48.37_AM.png (345×335 px, 43 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21400.May 8 2014, 3:51 PM
epriestley retitled this revision from to Move audit rendering into SearchEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4986: Implement new Dashboard panel types.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 8 2014, 3:51 PM
Harbormaster completed remote builds in B302: Diff 21400.May 8 2014, 3:52 PM
btrahan accepted this revision.May 8 2014, 6:56 PM
btrahan edited edge metadata.

I recall the ListView->getRequiredHandlePHIDs weirdness from my query and associated stuff consolidation in audit. I'll try to take it out next time I'm in the area.

This revision is now accepted and ready to land.May 8 2014, 6:56 PM
epriestley closed this revision.May 9 2014, 3:04 AM
epriestley updated this revision to Diff 21425.

Closed by commit rPc72b753e5407 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
controller/
22 lines
query/
31 lines
feed/
query/
2 lines
search/
engine/
4 lines
slowvote/
query/
2 lines

Diff 21425

View Options

src/applications/audit/controller/PhabricatorAuditListController.php

Loading...
View Options

src/applications/audit/query/PhabricatorCommitSearchEngine.php

Loading...
View Options

src/applications/feed/query/PhabricatorFeedSearchEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
View Options

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

Loading...
Phabricator · Built by Phacility