Page MenuHomePhabricator
Differential D8989

Add an XML linter.
ClosedPublic
Actions

Authored by joshuaspence on May 6 2014, 2:38 AM.
Tags
None
Referenced Files
F14028033: D8989.id21346.diff
Fri, Nov 8, 11:27 AM
F14014423: D8989.id21343.diff
Sun, Nov 3, 3:16 AM
F13994415: D8989.id21343.diff
Wed, Oct 23, 5:59 AM
F13983905: D8989.diff
Sun, Oct 20, 9:35 AM
F13971775: D8989.diff
Thu, Oct 17, 3:17 PM
F13971769: D8989.id.diff
Thu, Oct 17, 3:12 PM
F13971766: D8989.id21343.diff
Thu, Oct 17, 3:11 PM
F13971750: D8989.id21346.diff
Thu, Oct 17, 3:07 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCe00ce652001b: Add an XML linter.
Summary

Add a linter which uses SimpleXML to detect errors and potential problems in XML files.

Test Plan

Wrote and executed unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 21343.May 6 2014, 2:38 AM
joshuaspence retitled this revision from to Add an XML linter..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 6 2014, 2:38 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B261: Diff 21343.May 6 2014, 2:40 AM
epriestley accepted this revision.May 6 2014, 3:15 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 6 2014, 3:15 AM
epriestley closed this revision.May 6 2014, 3:16 AM
epriestley updated this revision to Diff 21346.

Closed by commit rARCe00ce652001b (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Diff 21346

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/ArcanistXMLLinter.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistXMLLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/xml/almost-empty.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/attr1.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/attr2.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/attr3.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/attr4.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/big-entity-name.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/big-name-1.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/big-name-2.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/cdata-1.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/cdata-2.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/char-ref.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/comment.list-test

Loading...
View Options

src/lint/linter/__tests__/xml/empty-cdata.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/empty.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/gjobs.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/languages-1.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/languages-2.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/languages-3.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/languages-4.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/languages-5.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/languages-6.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/languages-7.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/slashdot.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/svg.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/title.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/xhtml.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/xlink.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/youtube.lint-test

Loading...
Phabricator · Built by Phacility