Page MenuHomePhabricator

Improve accessibility of some UI elements (forms, icons, timeline)
ClosedPublic

Authored by epriestley on May 4 2014, 11:01 PM.
Tags
None
Referenced Files
F13157380: D8978.id21304.diff
Sun, May 5, 11:20 AM
Unknown Object (File)
Fri, May 3, 3:15 AM
Unknown Object (File)
Thu, May 2, 4:14 PM
Unknown Object (File)
Mon, Apr 29, 2:33 PM
Unknown Object (File)
Thu, Apr 25, 10:19 PM
Unknown Object (File)
Thu, Apr 25, 10:19 PM
Unknown Object (File)
Wed, Apr 24, 10:09 PM
Unknown Object (File)
Fri, Apr 19, 3:35 AM
Subscribers

Details

Summary

Ref T4843. Chips away at a few more things.

Test Plan

Used VoiceOver and got a generally more sensible-seeming result.

Diff Detail

Repository
rP Phabricator
Branch
remarkup
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 242
Build 242: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Improve accessibility of some UI elements (forms, icons, timeline).
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
chad edited edge metadata.
This revision is now accepted and ready to land.May 5 2014, 1:58 AM

There's a small possibility that adding IDs to every form element will have unintended side effects, but I slept on it and couldn't come up with anything else to test. If inexplicable, peculiar behavior arises from forms after this lands this may be at fault, though.

epriestley updated this revision to Diff 21304.

Closed by commit rPcc8827a8c14d (authored by @epriestley).