Page MenuHomePhabricator
Differential D8973

Begin rebuilding dropdown menus on ActionList
ClosedPublic
Actions

Authored by epriestley on May 4 2014, 8:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 9:44 PM
Unknown Object (File)
Sat, Nov 16, 1:58 AM
Unknown Object (File)
Mon, Nov 11, 6:35 PM
Unknown Object (File)
Fri, Nov 8, 2:39 AM
Unknown Object (File)
Oct 22 2024, 1:22 PM
Unknown Object (File)
Oct 16 2024, 2:23 AM
Unknown Object (File)
Oct 13 2024, 6:42 AM
Unknown Object (File)
Oct 13 2024, 6:42 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rP56aa508f438d: Begin rebuilding dropdown menus on ActionList
Summary

Dropdown menus are entirely dynamic right now and use custom CSS. Begin rebuilding them to use ActionList CSS.

This introduces PHUIX components which are basically JS copy/pastes of the PHP PHUI components, just implemented in JS.

We have two other dropdowns: policy controls and one in Conpherence. I'll convert those, then implement D8966.

Test Plan

Screen_Shot_2014-05-04_at_1.06.22_PM.png (225×258 px, 15 KB)

Diff Detail

Repository
rP Phabricator
Branch
rm8
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 234
Build 234: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21291.May 4 2014, 8:12 PM
epriestley retitled this revision from to Begin rebuilding dropdown menus on ActionList.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 4 2014, 8:12 PM
Harbormaster completed remote builds in B234: Diff 21291.May 4 2014, 8:13 PM
chad edited edge metadata.May 4 2014, 8:20 PM

10155491_10152827803128662_7141446887684129943_n.jpg (531×800 px, 56 KB)

btrahan accepted this revision.May 5 2014, 4:44 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 5 2014, 4:44 PM
epriestley closed this revision.May 5 2014, 5:56 PM
epriestley updated this revision to Diff 21318.

Closed by commit rP56aa508f438d (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
98 lines
webroot/
rsrc/
css/
core/
3 lines
phui/
3 lines
externals/
javelin/
lib/
1 line
js/
application/
differential/
227 lines
phuix/
36 lines
138 lines
177 lines

Diff 21291

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/core/z-index.css

Loading...
View Options

webroot/rsrc/css/phui/phui-button.css

Loading...
View Options

webroot/rsrc/externals/javelin/lib/DOM.js

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-dropdown-menus.js

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXActionListView.js

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXActionView.js

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXDropdownMenu.js

Loading...
Phabricator · Built by Phacility