Page MenuHomePhabricator

Fix two parsing issues for diffs with damaged whitespace
ClosedPublic

Authored by epriestley on May 3 2014, 11:13 PM.
Tags
None
Referenced Files
F20859774: D8968.diff
Fri, Jun 26, 5:30 AM
Unknown Object (File)
Sat, Jun 20, 11:28 AM
Unknown Object (File)
Apr 14 2026, 10:14 PM
Unknown Object (File)
Apr 2 2026, 9:11 PM
Unknown Object (File)
Jan 17 2026, 9:43 PM
Unknown Object (File)
Dec 10 2025, 9:51 PM
Unknown Object (File)
Nov 9 2025, 7:06 PM
Unknown Object (File)
Nov 8 2025, 9:55 PM
Subscribers

Details

Summary

Fixes T4941. If a diff has had trailing whitespace stripped, we will fail to handle empty lines correctly (previously, these lines had a leading space when the original tool emitted them).

(This probably stopped working around the time we began retaining newlines.)

Test Plan

The diff in T4941 now parses and renders correctly.

Diff Detail

Repository
rP Phabricator
Branch
nlines
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 222
Build 222: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix two parsing issues for diffs with damaged whitespace.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, asherkin.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 4 2014, 5:35 PM
epriestley updated this revision to Diff 21286.

Closed by commit rPa272ddcc7869 (authored by @epriestley).