Page MenuHomePhabricator

Fix two parsing issues for diffs with damaged whitespace
ClosedPublic

Authored by epriestley on May 3 2014, 11:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 12, 4:24 AM
Unknown Object (File)
Tue, Jan 28, 9:49 PM
Unknown Object (File)
Fri, Jan 24, 2:48 PM
Unknown Object (File)
Thu, Jan 23, 7:47 PM
Unknown Object (File)
Jan 13 2025, 12:20 AM
Unknown Object (File)
Dec 22 2024, 10:29 PM
Unknown Object (File)
Dec 19 2024, 7:40 PM
Unknown Object (File)
Dec 14 2024, 4:15 AM
Subscribers

Details

Summary

Fixes T4941. If a diff has had trailing whitespace stripped, we will fail to handle empty lines correctly (previously, these lines had a leading space when the original tool emitted them).

(This probably stopped working around the time we began retaining newlines.)

Test Plan

The diff in T4941 now parses and renders correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix two parsing issues for diffs with damaged whitespace.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, asherkin.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 4 2014, 5:35 PM
epriestley updated this revision to Diff 21286.

Closed by commit rPa272ddcc7869 (authored by @epriestley).