Page MenuHomePhabricator

Fix two parsing issues for diffs with damaged whitespace
ClosedPublic

Authored by epriestley on May 3 2014, 11:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 4:15 AM
Unknown Object (File)
Sun, Dec 8, 3:21 PM
Unknown Object (File)
Sat, Dec 7, 7:07 PM
Unknown Object (File)
Tue, Dec 3, 1:16 PM
Unknown Object (File)
Tue, Dec 3, 12:11 PM
Unknown Object (File)
Wed, Nov 27, 4:26 PM
Unknown Object (File)
Tue, Nov 26, 1:35 AM
Unknown Object (File)
Nov 19 2024, 8:07 AM
Subscribers

Details

Summary

Fixes T4941. If a diff has had trailing whitespace stripped, we will fail to handle empty lines correctly (previously, these lines had a leading space when the original tool emitted them).

(This probably stopped working around the time we began retaining newlines.)

Test Plan

The diff in T4941 now parses and renders correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix two parsing issues for diffs with damaged whitespace.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, asherkin.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 4 2014, 5:35 PM
epriestley updated this revision to Diff 21286.

Closed by commit rPa272ddcc7869 (authored by @epriestley).