Page MenuHomePhabricator
Differential D8965

Modernize `ArcanistJSHintLinter`.
ClosedPublic
Actions

Authored by joshuaspence on May 3 2014, 6:22 AM.
Tags
None
Referenced Files
F13249630: D8965.diff
Fri, May 24, 9:55 AM
Unknown Object (File)
Apr 7 2024, 6:42 AM
Unknown Object (File)
Apr 2 2024, 11:17 PM
Unknown Object (File)
Mar 22 2024, 7:24 PM
Unknown Object (File)
Mar 22 2024, 7:24 PM
Unknown Object (File)
Jan 19 2024, 4:51 PM
Unknown Object (File)
Jan 15 2024, 5:20 PM
Unknown Object (File)
Jan 13 2024, 8:10 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCa7327ca0e943: Modernize `ArcanistJSHintLinter`.
Summary

Modernize ArcanistJSHintLinter by extending from ArcanistExternalLinter instead of ArcanistLinter.

Test Plan

Wrote and executed unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 21265.May 3 2014, 6:22 AM
joshuaspence retitled this revision from to Modernize `ArcanistJSHintLinter`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 3 2014, 6:22 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B216: Diff 21265.May 3 2014, 6:23 AM
joshuaspence added a comment.May 4 2014, 11:52 AM

Actually this overlaps a fair bit with D6810.

epriestley accepted this revision.May 5 2014, 9:22 PM
epriestley edited edge metadata.

Thanks!

This revision is now accepted and ready to land.May 5 2014, 9:22 PM
epriestley added inline comments.May 5 2014, 9:22 PM
src/lint/linter/__tests__/jshint/dot-notation.lint-test
3–4

My local copy doesn't raise these, but we can sort that out once the version stuff is in.

epriestley closed this revision.May 5 2014, 9:23 PM
epriestley updated this revision to Diff 21331.

Closed by commit rARCa7327ca0e943 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Diff 21331

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/ArcanistJSHintLinter.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistJSHintLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/jshint/dot-notation.lint-test

Loading...
View Options

src/lint/linter/__tests__/jshint/expected-conditional.lint-test

Loading...
View Options

src/lint/linter/__tests__/jshint/missing-semicolon.lint-test

Loading...
View Options

src/lint/linter/__tests__/jshint/unnecessary-semicolon.lint-test

Loading...
View Options

src/lint/linter/reporter.js

Loading...
Phabricator · Built by Phacility