Page MenuHomePhabricator

Transactions - make ctrl + enter submit ajax-style
ClosedPublic

Authored by btrahan on May 3 2014, 12:42 AM.
Tags
None
Referenced Files
F18734793: D8961.diff
Tue, Sep 30, 11:02 PM
F18717294: D8961.id.diff
Mon, Sep 29, 1:26 PM
F18705663: D8961.diff
Sun, Sep 28, 12:26 PM
F18704775: D8961.id21258.diff
Sun, Sep 28, 8:44 AM
F18636100: D8961.diff
Wed, Sep 17, 3:31 AM
F18304262: D8961.diff
Aug 23 2025, 10:33 PM
F18099562: D8961.id21258.diff
Aug 9 2025, 6:20 AM
F18099398: D8961.id21260.diff
Aug 9 2025, 4:33 AM
Subscribers

Details

Summary

We were correctly invoking a didSyntheticSubmit event on the form, but nothing was listening to it. Re-jigger the workflow submit code a tad so an onsyntheticsubmit event handler can be written to fill this gap. Fixes T4669.

Test Plan

edited comments, submitting both via clicking the button and apple + enter LIKE A BOSS

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Transactions - make ctrl + enter submit ajax-style.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

I poked at this for a bit but couldn't come up with anything cleaner, seems reasonable to me.

This revision is now accepted and ready to land.May 3 2014, 12:58 AM

yah, I didn't feel good about it, but someone has to win the ugly contest.

btrahan updated this revision to Diff 21260.

Closed by commit rPc995e93bc1c3 (authored by @btrahan).

btrahan edited edge metadata.