Page MenuHomePhabricator

Search - making clicking the search button not submit placeholder text
ClosedPublic

Authored by btrahan on May 2 2014, 11:52 PM.
Tags
None
Referenced Files
F19045162: D8960.id21259.diff
Nov 27 2025, 6:39 AM
F18880886: D8960.id.diff
Nov 6 2025, 8:46 PM
F18874854: D8960.diff
Nov 5 2025, 4:05 PM
F18762801: D8960.id.diff
Oct 6 2025, 8:41 PM
F18757177: D8960.diff
Oct 5 2025, 3:57 PM
F18734791: D8960.id.diff
Sep 30 2025, 11:02 PM
F18704505: D8960.id21257.diff
Sep 28 2025, 7:52 AM
F18696440: D8960.diff
Sep 27 2025, 7:50 AM
Subscribers

Details

Summary

Need to wire up the button to have a click handler that clears out the placeholder text. Fixes T4847.

Test Plan

Clicked the search button and got results for nothing as opposed to "Search." Typed a search and clicked button and got expected results.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Search - making clicking the search button not submit placeholder text.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 3 2014, 12:46 AM
btrahan updated this revision to Diff 21259.

Closed by commit rPbfa880328780 (authored by @btrahan).