Page MenuHomePhabricator

Search - making clicking the search button not submit placeholder text
ClosedPublic

Authored by btrahan on May 2 2014, 11:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 6:08 AM
Unknown Object (File)
Fri, May 3, 5:13 AM
Unknown Object (File)
Mon, Apr 29, 3:59 PM
Unknown Object (File)
Wed, Apr 24, 10:29 PM
Unknown Object (File)
Fri, Apr 12, 4:20 AM
Unknown Object (File)
Thu, Apr 11, 9:02 AM
Unknown Object (File)
Mar 24 2024, 7:21 AM
Unknown Object (File)
Mar 5 2024, 6:30 AM
Subscribers

Details

Summary

Need to wire up the button to have a click handler that clears out the placeholder text. Fixes T4847.

Test Plan

Clicked the search button and got results for nothing as opposed to "Search." Typed a search and clicked button and got expected results.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Search - making clicking the search button not submit placeholder text.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 3 2014, 12:46 AM
btrahan updated this revision to Diff 21259.

Closed by commit rPbfa880328780 (authored by @btrahan).