Page MenuHomePhabricator

Search - making clicking the search button not submit placeholder text
ClosedPublic

Authored by btrahan on May 2 2014, 11:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 23, 5:57 AM
Unknown Object (File)
Tue, Jan 21, 9:00 AM
Unknown Object (File)
Sat, Jan 18, 12:18 AM
Unknown Object (File)
Fri, Jan 17, 9:29 PM
Unknown Object (File)
Fri, Jan 17, 8:20 PM
Unknown Object (File)
Dec 26 2024, 6:31 AM
Unknown Object (File)
Dec 22 2024, 5:57 PM
Unknown Object (File)
Dec 15 2024, 10:56 PM
Subscribers

Details

Summary

Need to wire up the button to have a click handler that clears out the placeholder text. Fixes T4847.

Test Plan

Clicked the search button and got results for nothing as opposed to "Search." Typed a search and clicked button and got expected results.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Search - making clicking the search button not submit placeholder text.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 3 2014, 12:46 AM
btrahan updated this revision to Diff 21259.

Closed by commit rPbfa880328780 (authored by @btrahan).