Page MenuHomePhabricator
Differential D8958

Fix minor design nits, Herald
ClosedPublic
Actions

Authored by chad on May 2 2014, 8:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 26, 6:26 AM
Unknown Object (File)
Fri, Dec 20, 7:21 PM
Unknown Object (File)
Fri, Dec 13, 5:02 PM
Unknown Object (File)
Wed, Dec 11, 12:29 PM
Unknown Object (File)
Wed, Dec 11, 9:59 AM
Unknown Object (File)
Mon, Dec 9, 6:12 PM
Unknown Object (File)
Mon, Dec 9, 12:11 AM
Unknown Object (File)
Nov 27 2024, 1:21 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
Restricted Maniphest Task
T4803: ObjectItemList icons go wild on Herald
Commits
Restricted Diffusion Commit
rP83dc10f6ac4b: Fix minor design nits, Herald
Summary
  • Personal Rules display like globals
  • Remove "boxy" look around transcripts
  • Fix Property list widths, breaks, on mobile
  • Add proper blank state for no actions
Test Plan

Tested Herald on mobile and desktop, used simulator in Chrome

Diff Detail

Repository
rP Phabricator
Branch
no-herald
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 207
Build 207: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 21251.May 2 2014, 8:59 PM
chad retitled this revision from to Fix minor design nits, Herald.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptMay 2 2014, 8:59 PM
chad added a comment.May 2 2014, 8:59 PM

Screen_Shot_2014-05-02_at_1.57.36_PM.png (1×690 px, 141 KB)

Harbormaster completed remote builds in B207: Diff 21251.May 2 2014, 9:00 PM
chad updated this revision to Diff 21252.May 2 2014, 9:06 PM
  • Fix icon pane on mobile
Harbormaster completed remote builds in B208: Diff 21252.May 2 2014, 9:07 PM
epriestley accepted this revision.May 2 2014, 9:15 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 2 2014, 9:15 PM
chad closed this revision.May 2 2014, 9:26 PM
chad updated this revision to Diff 21255.

Closed by commit rP83dc10f6ac4b (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
applications/
herald/
controller/
1 line
8 lines
webroot/
rsrc/
css/
phui/
5 lines
7 lines

Diff 21251

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleListController.php

Loading...
View Options

src/applications/herald/controller/HeraldTranscriptListController.php

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-property-list-view.css

Loading...
Phabricator · Built by Phacility