Differential D8952

Transactions - fix edit submit URI
ClosedPublic
Actions

Authored by btrahan on May 2 2014, 4:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 2, 10:37 AM

	Unknown Object (File)
	Tue, Apr 2, 1:36 AM

	Unknown Object (File)
	Sun, Mar 31, 10:21 PM

	Unknown Object (File)
	Thu, Mar 28, 6:38 PM

	Unknown Object (File)
	Sat, Mar 23, 1:19 PM

	Unknown Object (File)
	Thu, Mar 21, 5:31 AM

	Unknown Object (File)
	Feb 3 2024, 6:00 PM

	Unknown Object (File)
	Jan 29 2024, 12:16 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T4669: Submitting comment edits with ctrl+enter doesn't ajax

Commits

Restricted Diffusion Commit
rP4e4a520b783e: Transactions - fix edit submit URI

Summary

tracing this a bit, in core/behavior-form.js we end up doing form.submit() on this form. Before this patch, the form had no submitURI set so it ended up doing a page load. Now, we set the submitURI and (at least) the form is actually submitted and data is saved. Ref T4669.

Not sure how come the syntheticSubmit even isn't getting picked up though?

Test Plan

hit apple + enter to submit comment edit. page reloaded and my edit persisted!

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 21241.May 2 2014, 4:30 PM

btrahan added a task: T4669: Submitting comment edits with ctrl+enter doesn't ajax.

btrahan retitled this revision from to Transactions - fix edit submit URI.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptMay 2 2014, 4:30 PM

Harbormaster completed remote builds in B199: Diff 21241.May 2 2014, 4:31 PM

epriestley accepted this revision.May 2 2014, 4:34 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/transactions/application/PhabricatorApplicationTransactions.php
13–15 ↗	(On Diff #21241)	(I think this might have a weird side effect like making it show up in the main menu search typeahead?)

This revision is now accepted and ready to land.May 2 2014, 4:34 PM

epriestley added inline comments.May 2 2014, 4:35 PM

src/applications/transactions/controller/PhabricatorApplicationTransactionCommentEditController.php
61–64	Oh, using $this->newDialog() might also fix this, since that should set a default submit URI based on the request URI.

remove getBaseURI - it makes Transactions show up as an application search result

Closed by commit rP4e4a520b783e (authored by @btrahan).

Harbormaster completed remote builds in B200: Diff 21242.May 2 2014, 4:38 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

controller/

PhabricatorApplicationTransactionCommentEditController.php

2 lines

Diff 21243

src/applications/transactions/controller/PhabricatorApplicationTransactionCommentEditController.php

Loading...