Page MenuHomePhabricator

Ask users to choose a pronoun instead of sex in the Account settings panel
ClosedPublic

Authored by lpriestley on Apr 30 2014, 9:13 PM.
Tags
None
Referenced Files
F15760464: D8920.id21168.diff
Fri, May 30, 3:39 AM
Unknown Object (File)
Thu, May 29, 1:07 AM
Unknown Object (File)
Wed, May 28, 3:46 PM
Unknown Object (File)
Tue, May 27, 9:31 AM
Unknown Object (File)
Mon, May 26, 6:25 AM
Unknown Object (File)
Tue, May 13, 5:47 PM
Unknown Object (File)
Apr 29 2025, 10:56 PM
Unknown Object (File)
Apr 24 2025, 11:30 PM
Subscribers
Tokens
"Love" token, awarded by qgil.

Details

Summary

Fixes T4845, Use "choose a pronoun" prompt for (grammatical) gender selection instead of "Sex"

Test Plan

Open Account settings panel, expand Pronoun dropdown, verify that options are "<username> updated their/her/his profile". Switch to different language, verify that pronouns propogate

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

lpriestley retitled this revision from to Ask users to choose a pronoun instead of sex in the Account settings panel.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/settings/panel/PhabricatorSettingsPanelAccount.php
64–65

These two are flipped (male => her).

This revision now requires changes to proceed.Apr 30 2014, 9:26 PM
lpriestley edited edge metadata.

Addressing feedback, fixing his/her mapping

epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 30 2014, 9:41 PM
epriestley updated this revision to Diff 21169.

Closed by commit rPcf3f8cd809b4 (authored by @lpriestley, committed by @epriestley).