Paths

Table of Contentst

Fix Diffusion crash
ClosedPublic
Actions

Authored by hach-que on Apr 30 2014, 2:05 AM.

Tags

None

Referenced Files

	F14028827: D8906.id21140.diff
	Fri, Nov 8, 4:25 PM

	F14013881: D8906.diff
	Sat, Nov 2, 6:12 PM

	F14011859: D8906.diff
	Fri, Nov 1, 5:31 AM

	F13998746: D8906.diff
	Thu, Oct 24, 10:58 AM

	F13996271: D8906.id21141.diff
	Wed, Oct 23, 7:38 PM

	F13980423: D8906.diff
	Sat, Oct 19, 10:33 AM

	F13969205: D8906.id21140.diff
	Thu, Oct 17, 1:09 AM

	F13968347: D8906.id.diff
	Wed, Oct 16, 8:20 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP466af3314790: Fix Diffusion crash

Summary

This fixes a crash that happens when visiting Diffusion pages due to an undefined variable. $title is only defined if it has a status to show, but then it uses it anyway and fails.

Test Plan

Pages stopped crashing and people stopped complaining.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

hach-que updated this revision to Diff 21140.Apr 30 2014, 2:05 AM

hach-que retitled this revision from to Fix Diffusion crash.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 30 2014, 2:05 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B138: Diff 21140.Apr 30 2014, 2:06 AM

epriestley accepted this revision.Apr 30 2014, 2:06 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 30 2014, 2:06 AM

Closed by commit rP466af3314790 (authored by @jamesr, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionController.php

1 line

Diff 21141

View Options

src/applications/diffusion/controller/DiffusionController.php

Fix Diffusion crashClosedPublicActions