Differential D8882

Make JOIN changes to CommitQuery only
ClosedPublic
Actions

Authored by epriestley on Apr 28 2014, 12:28 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T4911: Receiving "Failed to load the commit because the commit has not been parsed yet." after updating phabricator.

Commits

Restricted Diffusion Commit
rP8716e734f039: Make JOIN changes to CommitQuery only

Summary

Fixes T4911. See D8879. This gives us the correct query in cases where there are no audits.

This doesn't try to do the GROUP BY stuff yet.

Test Plan

Viewed a commit in Diffusion with no audits, got a commit detail page.
Viewed "All Commits" in web UI, saw commits without any audits included in the list.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21069.Apr 28 2014, 12:28 PM

epriestley retitled this revision from to Make JOIN changes to CommitQuery only.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4911: Receiving "Failed to load the commit because the commit has not been parsed yet." after updating phabricator..

Herald added a subscriber: epriestley. · View Herald TranscriptApr 28 2014, 12:28 PM

Harbormaster completed remote builds in B97: Diff 21069.Apr 28 2014, 12:29 PM

btrahan accepted this revision.Apr 28 2014, 3:07 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 28 2014, 3:07 PM

Closed by commit rP8716e734f039 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

query/

DiffusionCommitQuery.php

55 lines

Diff 21070

View Options

src/applications/diffusion/query/DiffusionCommitQuery.php

Make JOIN changes to CommitQuery onlyClosedPublicActions