Page MenuHomePhabricator
Differential D8863

Fix quick create on mobile
ClosedPublic
Actions

Authored by epriestley on Apr 25 2014, 8:28 PM.
Tags
None
Referenced Files
F13816865: D8863.diff
Thu, Sep 19, 7:30 PM
Unknown Object (File)
Sun, Aug 25, 7:48 PM
Unknown Object (File)
Sun, Aug 25, 9:29 AM
Unknown Object (File)
Fri, Aug 23, 5:38 AM
Unknown Object (File)
Fri, Aug 23, 12:20 AM
Unknown Object (File)
Thu, Aug 22, 7:51 AM
Unknown Object (File)
Wed, Aug 21, 7:26 PM
Unknown Object (File)
Aug 20 2024, 2:03 AM
View All Files
Subscribers
epriestley
k

Details

Reviewers
chad
Maniphest Tasks
T4903: Fix quick create on mobile
Commits
Restricted Diffusion Commit
rP8fc5977b9afb: Fix quick create on mobile
Summary

Fixes T4903. At some point maybe-soonish we should maybe go make "device" => true the default, and put "device" => "hella-busted" on the remaining bad pages.

Test Plan

L@@K @ W/ iOS Simulator

Diff Detail

Repository
rP Phabricator
Branch
qcreate
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 71
Build 71: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21024.Apr 25 2014, 8:28 PM
epriestley retitled this revision from to Fix quick create on mobile.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4903: Fix quick create on mobile.
epriestley added a subscriber: k.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 25 2014, 8:28 PM
chad accepted this revision.Apr 25 2014, 8:29 PM
chad edited edge metadata.

yoink?

This revision is now accepted and ready to land.Apr 25 2014, 8:29 PM
Harbormaster completed remote builds in B71: Diff 21024.Apr 25 2014, 8:29 PM
epriestley added a comment.Apr 25 2014, 8:29 PM

Whoops, L@@K should be a hilarious eBay reference, not a mention of user @K.

epriestley updated this revision to Diff 21025.Apr 25 2014, 8:32 PM
epriestley edited edge metadata.
  • Also stop matching @@user as a mention.
  • Two completely unrelated changes in the same diff! Society is doomed.
epriestley added a comment.Apr 25 2014, 8:32 PM

"Yoink!" is the sound of me stealing the task from you, and thereby also stealing the opportunity to earn internet points.

Harbormaster completed remote builds in B72: Diff 21025.Apr 25 2014, 8:33 PM
chad added a comment.Apr 25 2014, 9:02 PM

have you read https://secure.phabricator.com/book/phabflavor/article/writing_reviewable_code/

chad added a comment.Apr 25 2014, 9:10 PM

nyancat

epriestley closed this revision.Apr 26 2014, 7:31 PM
epriestley updated this revision to Diff 21037.

Closed by commit rP8fc5977b9afb (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
home/
controller/
1 line

Diff 21024

View Options

src/applications/home/controller/PhabricatorHomeQuickCreateController.php

Loading...
Phabricator · Built by Phacility