Moderize Herald UI
ClosedPublic
Actions

Authored by chad on Apr 25 2014, 5:31 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rPc453e98c4093: Moderize Herald UI

Summary

Removes many tables and uses PropertyLists and ObjectItemList when possible. Adds cleaner CSS, makes mobile editing more possible.

Test Plan

Test new UI on desktop and mobile. Verify all functionality still exists.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad updated this revision to Diff 21018.Apr 25 2014, 5:31 PM

chad retitled this revision from to Moderize Herald UI.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptApr 25 2014, 5:31 PM

Screen_Shot_2014-04-25_at_10.27.57_AM.png (1×2 px, 147 KB)

Screen_Shot_2014-04-25_at_10.27.32_AM.png (1×2 px, 168 KB)

Screen_Shot_2014-04-25_at_10.27.21_AM.png (1×1 px, 174 KB)

Screen_Shot_2014-04-25_at_10.27.41_AM.png (1×2 px, 309 KB)

Harbormaster completed remote builds in B67: Diff 21018.Apr 25 2014, 5:32 PM

chad added a task: Restricted Maniphest Task.Apr 25 2014, 5:33 PM

Nice!

One minor thing: instead of "View Transcript" as a link, I think the transcript's main link should probably go to the transcript, and then we should either put like D1234 and link it in the attributes or just omit that entirely. I mess this up fairly often on the current UI (i.e., you 99% of the time want to go to the transcript from this UI, and it's confusing that the biggest link doesn't take you there). We can easily tweak this later, though.

This revision is now accepted and ready to land.Apr 26 2014, 8:43 PM