Differential D8852

Changed default timeout of smtp from 10s to 60s.
ClosedPublic
Actions

Authored by yehangjun on Apr 24 2014, 11:57 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP48f6bd9fea35: Changed default timeout of smtp from 10s to 60s.

Summary

Our smtp server responded slowly sometimes and reached the timeout, but actually
it had sent the email successfully. The mta then retried and sent duplicated
emails. So changed to a bigger default value.

Test Plan

Tested in our deployed and it worked

Diff Detail

Repository

rP Phabricator

Branch

smtp-timeout

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 58
Build 58: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

yehangjun updated this revision to Diff 21003.Apr 24 2014, 11:57 AM

yehangjun retitled this revision from to Changed default timeout of smtp from 10s to 60s..

yehangjun updated this object.

yehangjun edited the test plan for this revision. (Show Details)

yehangjun added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 24 2014, 11:57 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Thanks!

This revision is now accepted and ready to land.Apr 24 2014, 11:58 AM

Harbormaster completed remote builds in B58: Diff 21003.Apr 24 2014, 11:58 AM

Closed by commit rP48f6bd9fea35 (authored by @yehangjun, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

externals/

phpmailer/

class.phpmailer.php

2 lines

Diff 21003

View Options

externals/phpmailer/class.phpmailer.php

Changed default timeout of smtp from 10s to 60s.ClosedPublicActions