Fix a HunkQuery issue where no hunks load at all
ClosedPublic
Actions

Authored by epriestley on Apr 22 2014, 10:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jan 13, 12:26 PM

	Unknown Object (File)
	Sun, Jan 12, 7:05 PM

	Unknown Object (File)
	Mon, Jan 6, 8:39 PM

	Unknown Object (File)
	Sat, Jan 4, 1:23 PM

	Unknown Object (File)
	Wed, Jan 1, 8:53 PM

	Unknown Object (File)
	Dec 15 2024, 11:22 PM

	Unknown Object (File)
	Dec 4 2024, 8:17 AM

	Unknown Object (File)
	Nov 27 2024, 11:15 PM

View All Files

Subscribers

epriestley

zeeg

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP5f033d580c58: Fix a HunkQuery issue where no hunks load at all

Summary

If you create a diff with no hunks (e.g., it adds a single empty file), we never attachHunks() so we throw on getHunks().

Instead, make sure changesets get hunks attached if they expect it.

Test Plan

Created a new diff with a single empty file in it.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20979.Apr 22 2014, 10:29 PM

epriestley retitled this revision from to Fix a HunkQuery issue where no hunks load at all.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 22 2014, 10:29 PM

Harbormaster completed remote builds in B45: Diff 20979.Apr 22 2014, 10:30 PM

@zeeg, this should fix the issue you ran into yesterday.

btrahan accepted this revision.Apr 23 2014, 7:00 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 23 2014, 7:00 PM

Closed by commit rP5f033d580c58 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

query/

DifferentialHunkQuery.php

13 lines

Diff 20993

View Options

src/applications/differential/query/DifferentialHunkQuery.php

Fix a HunkQuery issue where no hunks load at allClosedPublicActions