Page MenuHomePhabricator
Differential D8836

Fix JIRA issue URI selection for JIRA installs which are not on the domain root
ClosedPublic
Actions

Authored by epriestley on Apr 22 2014, 1:37 PM.
Tags
None
Referenced Files
F14068417: D8836.diff
Tue, Nov 19, 9:49 PM
F14067776: D8836.id21805.diff
Tue, Nov 19, 5:10 PM
F14067775: D8836.id20969.diff
Tue, Nov 19, 5:10 PM
F14067774: D8836.id21804.diff
Tue, Nov 19, 5:10 PM
F14043489: D8836.id20969.diff
Tue, Nov 12, 10:33 AM
F14037258: D8836.diff
Sun, Nov 10, 2:39 PM
F14033337: D8836.diff
Sat, Nov 9, 5:29 PM
F13981482: D8836.id.diff
Oct 19 2024, 4:50 PM
View All Files
Subscribers
epriestley
salehe

Details

Reviewers
btrahan
Maniphest Tasks
T4859: "JIRA issues" integration problems when JIRA is NOT configured on the root of domain
Commits
Restricted Diffusion Commit
rP7a9d5f8f2de5: Fix JIRA issue URI selection for JIRA installs which are not on the domain root
Summary

Fixes T4859. See that for details.

Test Plan
  • Verified things still work on my local (domain root) install.
  • Added some unit tests.
  • Did not verify a non-root install since I don't have one handy, hopefully @salehe can help.

Diff Detail

Repository
rP Phabricator
Branch
jira1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 551
Build 551: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 20969.Apr 22 2014, 1:37 PM
epriestley retitled this revision from to Fix JIRA issue URI selection for JIRA installs which are not on the domain root.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4859: "JIRA issues" integration problems when JIRA is NOT configured on the root of domain.
epriestley added a subscriber: salehe.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 22 2014, 1:37 PM
Harbormaster completed remote builds in B39: Diff 20969.Apr 22 2014, 1:39 PM
btrahan accepted this revision.Apr 23 2014, 6:59 PM
btrahan edited edge metadata.

I think we'll eventually have to have a box just running all this software we integrate with.

This revision is now accepted and ready to land.Apr 23 2014, 6:59 PM
epriestley added a comment.Apr 23 2014, 8:02 PM

I have a local install, but this would have required adding a second local install. But, yeah, we can improve this some day.

(I'm going to make a small, similar edit to deal with the other note in T4859 before I land this.)

btrahan added a comment.Apr 23 2014, 8:03 PM

...I on the other hand have never fully tested a JIRA integration. :/

epriestley added a comment.Apr 23 2014, 8:05 PM

It wasn't that big of a pain to set up but it's really slow when it starts up, and my free trial is expired now.

Some day we're probably going to have to buy JIRA licenses. :o

epriestley updated this revision to Diff 21804.May 18 2014, 12:45 PM
epriestley edited edge metadata.
  • Include a fix for the Remarkup rule.
epriestley closed this revision.May 18 2014, 12:45 PM
epriestley updated this revision to Diff 21805.

Closed by commit rP7a9d5f8f2de5 (authored by @epriestley).

Harbormaster completed remote builds in B551: Diff 21804.May 18 2014, 12:46 PM

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
doorkeeper/
bridge/
30 lines
__tests__/
37 lines
remarkup/
4 lines

Diff 21804

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/doorkeeper/bridge/DoorkeeperBridgeJIRA.php

Loading...
View Options

src/applications/doorkeeper/bridge/__tests__/DoorkeeperBridgeJIRATestCase.php

Loading...
View Options

src/applications/doorkeeper/remarkup/DoorkeeperRemarkupRuleJIRA.php

Loading...
Phabricator · Built by Phacility