Page MenuHomePhabricator
Differential D8821

Remove loadPhabricatorRepository from ReleephProject
ClosedPublic
Actions

Authored by epriestley on Apr 19 2014, 5:35 PM.
Tags
None
Referenced Files
F14027600: D8821.diff
Fri, Nov 8, 8:03 AM
F14007581: D8821.diff
Tue, Oct 29, 8:23 AM
F13982664: D8821.id20930.diff
Sun, Oct 20, 1:00 AM
F13982656: D8821.id.diff
Sun, Oct 20, 12:57 AM
F13982653: D8821.id20939.diff
Sun, Oct 20, 12:56 AM
F13963563: D8821.id20939.diff
Tue, Oct 15, 4:38 PM
Unknown Object (File)
Sep 27 2024, 8:07 AM
Unknown Object (File)
Sep 20 2024, 4:52 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPa588955bf79e: Remove loadPhabricatorRepository from ReleephProject
Summary

Ref T3551. Repository is guaranteed if a product is loaded with modern mechanisms.

Test Plan
  • Edited a request.
  • Called releephwork.getbranchcommitmessage.

Diff Detail

Repository
rP Phabricator
Branch
rel6
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/releeph/conduit/work/ConduitAPI_releephwork_getbranchcommitmessage_Method.php:58XHP16TODO Comment
Unit
No Test Coverage
Build Status
Buildable 18
Build 18: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 20930.Apr 19 2014, 5:35 PM
epriestley retitled this revision from to Remove loadPhabricatorRepository from ReleephProject.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: Restricted Maniphest Task.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 19 2014, 5:35 PM
Harbormaster completed remote builds in B18: Diff 20930.Apr 19 2014, 5:37 PM
btrahan accepted this revision.Apr 20 2014, 4:43 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2014, 4:43 PM
epriestley closed this revision.Apr 20 2014, 6:55 PM
epriestley updated this revision to Diff 20939.

Closed by commit rPa588955bf79e (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
releeph/
conduit/
work/
3 lines
controller/
request/
2 lines
storage/
8 lines

Diff 20930

View Options

src/applications/releeph/conduit/work/ConduitAPI_releephwork_getbranchcommitmessage_Method.php

Loading...
View Options

src/applications/releeph/controller/request/ReleephRequestEditController.php

Loading...
View Options

src/applications/releeph/storage/ReleephProject.php

Loading...
Phabricator · Built by Phacility