Page MenuHomePhabricator

Remove some ad-hoc handle loads from Releeph
ClosedPublic

Authored by epriestley on Apr 19 2014, 4:47 PM.
Tags
None
Referenced Files
F18593456: D8819.diff
Fri, Sep 12, 2:59 PM
F18195316: D8819.diff
Aug 17 2025, 3:10 PM
F18116867: D8819.diff
Aug 13 2025, 7:43 AM
F18098361: D8819.diff
Aug 8 2025, 7:44 PM
F18049301: D8819.diff
Aug 3 2025, 3:58 PM
F17912520: D8819.id20937.diff
Jul 29 2025, 4:23 PM
F17904541: D8819.id20937.diff
Jul 29 2025, 11:27 AM
F17891908: D8819.diff
Jul 29 2025, 4:21 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPa4f975ef3e45: Remove some ad-hoc handle loads from Releeph
Summary

Ref T3551. Releeph does a bunch of old-school on-object data loading; start cleaning that up.

This doesn't change anything, just makes the code more modern/consistent.

Test Plan

Edited a request; called releephwork.nextrequest.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Remove some ad-hoc handle loads from Releeph.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: Restricted Maniphest Task.
  • Remove some more handle-related stuff.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/releeph/conduit/work/ConduitAPI_releephwork_nextrequest_Method.php
49–53

seems about right for a conduit method called "next request" :P

This revision is now accepted and ready to land.Apr 20 2014, 4:31 PM
epriestley updated this revision to Diff 20937.

Closed by commit rPa4f975ef3e45 (authored by @epriestley).