Page MenuHomePhabricator
Differential D8819

Remove some ad-hoc handle loads from Releeph
ClosedPublic
Actions

Authored by epriestley on Apr 19 2014, 4:47 PM.
Tags
None
Referenced Files
F15277956: D8819.diff
Sun, Mar 2, 5:25 PM
Unknown Object (File)
Thu, Feb 27, 8:14 AM
Unknown Object (File)
Tue, Feb 25, 8:07 PM
Unknown Object (File)
Fri, Feb 21, 12:56 AM
Unknown Object (File)
Tue, Feb 18, 5:11 PM
Unknown Object (File)
Sun, Feb 16, 3:46 AM
Unknown Object (File)
Wed, Feb 12, 10:24 PM
Unknown Object (File)
Mon, Feb 10, 4:51 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPa4f975ef3e45: Remove some ad-hoc handle loads from Releeph
Summary

Ref T3551. Releeph does a bunch of old-school on-object data loading; start cleaning that up.

This doesn't change anything, just makes the code more modern/consistent.

Test Plan

Edited a request; called releephwork.nextrequest.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20926.Apr 19 2014, 4:47 PM
epriestley retitled this revision from to Remove some ad-hoc handle loads from Releeph.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: Restricted Maniphest Task.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 19 2014, 4:47 PM
Harbormaster completed remote builds in B15: Diff 20926.Apr 19 2014, 4:48 PM
epriestley updated this revision to Diff 20927.Apr 19 2014, 4:52 PM
  • Remove some more handle-related stuff.
Harbormaster completed remote builds in B16: Diff 20927.Apr 19 2014, 4:53 PM
btrahan accepted this revision.Apr 20 2014, 4:31 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/releeph/conduit/work/ConduitAPI_releephwork_nextrequest_Method.php
49–53

seems about right for a conduit method called "next request" :P

This revision is now accepted and ready to land.Apr 20 2014, 4:31 PM
epriestley closed this revision.Apr 20 2014, 6:54 PM
epriestley updated this revision to Diff 20937.

Closed by commit rPa4f975ef3e45 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
releeph/
conduit/
18 lines
work/
11 lines
controller/
request/
15 lines
field/
specification/
24 lines
storage/
40 lines
12 lines

Diff 20937

View Options

src/applications/releeph/conduit/ConduitAPI_releeph_request_Method.php

Loading...
View Options

src/applications/releeph/conduit/work/ConduitAPI_releephwork_nextrequest_Method.php

Loading...
View Options

src/applications/releeph/controller/request/ReleephRequestEditController.php

Loading...
View Options

src/applications/releeph/field/specification/ReleephBranchCommitFieldSpecification.php

Loading...
View Options

src/applications/releeph/storage/ReleephBranch.php

Loading...
View Options

src/applications/releeph/storage/ReleephRequest.php

Loading...
Phabricator · Built by Phacility