Page MenuHomePhabricator
Differential D8810

Use standard handle loading in Releeph
ClosedPublic
Actions

Authored by epriestley on Apr 18 2014, 9:29 PM.
Tags
None
Referenced Files
F14027618: D8810.diff
Fri, Nov 8, 8:07 AM
F13984055: D8810.id20920.diff
Sun, Oct 20, 10:43 AM
F13982456: D8810.id20909.diff
Sat, Oct 19, 11:28 PM
F13982452: D8810.id.diff
Sat, Oct 19, 11:25 PM
F13982451: D8810.id20920.diff
Sat, Oct 19, 11:24 PM
Unknown Object (File)
Oct 6 2024, 9:05 PM
Unknown Object (File)
Sep 19 2024, 8:22 PM
Unknown Object (File)
Sep 19 2024, 8:20 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPfde4ccf9b2cf: Use standard handle loading in Releeph
Summary

Ref T3718. Move from unbatched / ad-hoc loading to standard stuff for handles.

Test Plan

Looked at some requests and saw no changes.

Diff Detail

Repository
rP Phabricator
Branch
rel2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5
Build 5: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 20909.Apr 18 2014, 9:29 PM
epriestley retitled this revision from to Use standard handle loading in Releeph.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: Restricted Maniphest Task.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 18 2014, 9:29 PM
Harbormaster completed remote builds in B5: Diff 20909.Apr 18 2014, 9:30 PM
btrahan accepted this revision.Apr 19 2014, 12:26 AM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 19 2014, 12:26 AM
epriestley closed this revision.Apr 19 2014, 12:52 AM
epriestley updated this revision to Diff 20920.

Closed by commit rPfde4ccf9b2cf (authored by @epriestley).

Revision Contents
Changeset List

Diff 20909

View Options

src/applications/differential/customfield/DifferentialCustomField.php

Loading...
View Options

src/applications/releeph/field/specification/ReleephAuthorFieldSpecification.php

Loading...
View Options

src/applications/releeph/field/specification/ReleephDependsOnFieldSpecification.php

Loading...
View Options

src/applications/releeph/field/specification/ReleephDiffSizeFieldSpecification.php

Loading...
View Options

src/applications/releeph/field/specification/ReleephFieldSpecification.php

Loading...
View Options

src/applications/releeph/field/specification/ReleephIntentFieldSpecification.php

Loading...
View Options

src/applications/releeph/field/specification/ReleephOriginalCommitFieldSpecification.php

Loading...
View Options

src/applications/releeph/field/specification/ReleephRequestorFieldSpecification.php

Loading...
View Options

src/applications/releeph/field/specification/ReleephRevisionFieldSpecification.php

Loading...
View Options

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...
Phabricator · Built by Phacility