Paths

Table of Contentst

Differential D8803

Record build success or failure on buildable objects
ClosedPublic
Actions

Authored by epriestley on Apr 17 2014, 7:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 14, 9:06 PM

	Unknown Object (File)
	Thu, Dec 12, 12:47 AM

	Unknown Object (File)
	Wed, Dec 11, 7:40 PM

	Unknown Object (File)
	Sat, Nov 30, 3:30 AM

	Unknown Object (File)
	Fri, Nov 29, 9:57 AM

	Unknown Object (File)
	Mon, Nov 25, 6:37 AM

	Unknown Object (File)
	Wed, Nov 20, 11:30 PM

	Unknown Object (File)
	Nov 17 2024, 12:23 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T1049: Implement Harbormaster
T4810: When builds finish, post a transaction to the buildable

Commits

Restricted Diffusion Commit
rP95a405da1090: Record build success or failure on buildable objects

Summary

Fixes T4810. When a buildable completes, make an effort to update the corresponding object with a success or failure message. Commits don't support this yet, but revisions do.

Screen_Shot_2014-04-17_at_12.24.35_PM.png (119×409 px, 11 KB)

Test Plan

Used bin/harbormaster build and bin/harbormaster update to run a pile of builds.
Tried good/bad builds.
Sent some normal mail to make sure the mail reentrancy change didn't break stuff.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20884.Apr 17 2014, 7:34 PM

epriestley retitled this revision from to Record build success or failure on buildable objects.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4810: When builds finish, post a transaction to the buildable.

Herald added a subscriber: epriestley.Apr 17 2014, 7:34 PM

Don't send email for passing results by default.

btrahan accepted this revision.Apr 17 2014, 8:39 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 17 2014, 8:39 PM

Closed by commit rP95a405da1090 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

engine/

HarbormasterBuildEngine.php

56 lines

metamta/

storage/

PhabricatorMetaMTAMail.php

25 lines

transactions/

constants/

PhabricatorTransactions.php

1 line

editor/

PhabricatorApplicationTransactionEditor.php

10 lines

storage/

PhabricatorApplicationTransaction.php

77 lines

Diff 20899

src/applications/harbormaster/engine/HarbormasterBuildEngine.php

Loading...

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

Loading...

src/applications/transactions/constants/PhabricatorTransactions.php

Loading...

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...