Page MenuHomePhabricator

Record build success or failure on buildable objects
ClosedPublic

Authored by epriestley on Apr 17 2014, 7:34 PM.
Tags
None
Referenced Files
F12835126: D8803.diff
Thu, Mar 28, 3:00 PM
Unknown Object (File)
Wed, Mar 27, 5:26 PM
Unknown Object (File)
Wed, Mar 27, 5:26 PM
Unknown Object (File)
Wed, Mar 27, 5:26 PM
Unknown Object (File)
Wed, Mar 27, 5:26 PM
Unknown Object (File)
Wed, Mar 27, 5:26 PM
Unknown Object (File)
Tue, Mar 26, 7:05 AM
Unknown Object (File)
Tue, Mar 26, 7:05 AM
Subscribers

Details

Summary

Fixes T4810. When a buildable completes, make an effort to update the corresponding object with a success or failure message. Commits don't support this yet, but revisions do.

Screen_Shot_2014-04-17_at_12.24.35_PM.png (119×409 px, 11 KB)

Test Plan
  • Used bin/harbormaster build and bin/harbormaster update to run a pile of builds.
  • Tried good/bad builds.
  • Sent some normal mail to make sure the mail reentrancy change didn't break stuff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Record build success or failure on buildable objects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Don't send email for passing results by default.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 17 2014, 8:39 PM
epriestley updated this revision to Diff 20899.

Closed by commit rP95a405da1090 (authored by @epriestley).