Show build results in `arc land`
ClosedPublic
Actions

Authored by epriestley on Apr 17 2014, 5:07 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T1049: Implement Harbormaster
T4809: Make "arc land" complain if builds are still executing or have failed

Commits

rARC6e597b292ad1: Show build results in `arc land`

Summary

Fixes T4809. When landing a revision, check for a (non-manual) buildable of the current diff. If we find one, check its status:

If it passed, print out a message to inform the user that we checked.
If it failed or is still building, print out details about the issue and require a confirmation to continue.
Just ignore other cases.

Test Plan

Ran arc land on a revision with no buildable, a passing buildable, a failed buildable, and a building buildable for the current diff.
Got sensible output / prompts.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20882.Apr 17 2014, 5:07 PM

epriestley retitled this revision from to Show build results in `arc land`.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4809: Make "arc land" complain if builds are still executing or have failed.

Herald added a subscriber: epriestley.Apr 17 2014, 5:07 PM

Prompt looks something like this:

Harbormaster failed to build the current diff for this revision. Build failures:

     FAILED  Build 127: Always Throw An Exception

You can review build details here:

    Harbormaster URI: http://local.aphront.com:8080/B116

    Land revision anyway, despite build failures? [y/N]

btrahan accepted this revision.Apr 17 2014, 6:33 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 17 2014, 6:33 PM

btrahan added inline comments.Apr 17 2014, 6:34 PM