Page MenuHomePhabricator

Show build results in `arc land`
ClosedPublic

Authored by epriestley on Apr 17 2014, 5:07 PM.

Details

Summary

Fixes T4809. When landing a revision, check for a (non-manual) buildable of the current diff. If we find one, check its status:

  • If it passed, print out a message to inform the user that we checked.
  • If it failed or is still building, print out details about the issue and require a confirmation to continue.
  • Just ignore other cases.
Test Plan
  • Ran arc land on a revision with no buildable, a passing buildable, a failed buildable, and a building buildable for the current diff.
  • Got sensible output / prompts.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Show build results in `arc land`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.

Prompt looks something like this:

Harbormaster failed to build the current diff for this revision. Build failures:

     FAILED  Build 127: Always Throw An Exception

You can review build details here:

    Harbormaster URI: http://local.aphront.com:8080/B116

    Land revision anyway, despite build failures? [y/N]
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 17 2014, 6:33 PM
src/workflow/ArcanistLandWorkflow.php
1176โ€“1178

I would guess this is still what we do even when harbormaster is out of beta.

src/workflow/ArcanistLandWorkflow.php
1176โ€“1178

Yeah -- if there's another version bump in the future we could theoretically adjust this a bit, but you're probably right.

epriestley updated this revision to Diff 20892.

Closed by commit rARC6e597b292ad1 (authored by @epriestley).