Page MenuHomePhabricator

Add "harbormaster.querybuilds" Conduit API
ClosedPublic

Authored by epriestley on Apr 16 2014, 10:16 PM.
Tags
None
Referenced Files
F14060627: D8795.diff
Mon, Nov 18, 2:28 AM
F14033816: D8795.diff
Sat, Nov 9, 8:16 PM
F14006988: D8795.id20894.diff
Mon, Oct 28, 9:58 PM
F14006987: D8795.id20870.diff
Mon, Oct 28, 9:58 PM
F14006986: D8795.id20869.diff
Mon, Oct 28, 9:58 PM
F14006985: D8795.id.diff
Mon, Oct 28, 9:58 PM
F14006931: D8795.diff
Mon, Oct 28, 9:32 PM
F14002550: D8795.diff
Fri, Oct 25, 7:58 PM
Subscribers

Details

Summary

Ref T4809. This one is more straightforward. A couple of tweaks:

  • Remove the WAITING status, since nothing ever sets it and I suspect nothing ever will with the modern way artifacts work (maybe). At a minimum, it's confusing with the new Target status that's also called "WAITING" but means something different.
  • Consolidate 17 copies of these status names into one method.
Test Plan

Ran some queries via Conduit, got reasonable looking results.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Add "harbormaster.querybuilds" Conduit API.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

<3 the 17 => 1 action.

This revision is now accepted and ready to land.Apr 16 2014, 10:32 PM
epriestley updated this revision to Diff 20894.

Closed by commit rP7c1bcdea1690 (authored by @epriestley).