Page MenuHomePhabricator

Separate repository updates from the pull daemon
ClosedPublic

Authored by epriestley on Apr 15 2014, 11:16 PM.
Tags
None
Referenced Files
F11164837: D8780.diff
Wed, Sep 28, 4:18 PM
Unknown Object (File)
Mon, Sep 26, 11:41 PM
Unknown Object (File)
Sat, Sep 24, 10:27 PM
Unknown Object (File)
Thu, Sep 22, 8:15 PM
Unknown Object (File)
Tue, Sep 20, 6:23 PM
Unknown Object (File)
Sun, Sep 18, 5:07 PM
Unknown Object (File)
Fri, Sep 16, 3:08 PM
Unknown Object (File)
Mon, Sep 12, 10:27 AM
Subscribers

Details

Summary

Ref T4605. Currently, the PullLocal daemon is responsible for two relatively distinct things:

  • scheduling repository updates; and
  • actually updating repositories.

Move the "actually updating" part into a new bin/repository update command, which basically runs the pull, discover, refs and mirror commands. This will let the parent process focus on scheduling in a more understandable way and update multiple repositories at once. It also makes it easier to debug and understand update behavior since the non-scheduling pipeline can be run separately.

Test Plan
  • Ran update --trace on SVN, Mercurial and Git repos.
  • Ran PullLocal daemon for a while without issues.

Diff Detail

Repository
rP Phabricator
Branch
pull1x
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

epriestley retitled this revision from to Separate repository updates from the pull daemon.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

Nice re-factor. If the answer to my inline question is "no" can we change the phlog to log to the daemon console?

src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php
140

this ends up showing up in the daemon log?

This revision is now accepted and ready to land.Apr 16 2014, 6:10 PM
src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php
140

Yeah, phlog() from daemons goes to the console (or, if it doesn't, that's a bug). I'll double-check.

Here's a screenshot of it hitting the daemon logs under real-world conditions:

Screen_Shot_2014-04-16_at_11.13.30_AM.png (344×1 px, 102 KB)

epriestley updated this revision to Diff 20857.

Closed by commit rP118c696f727a (authored by @epriestley).