Page MenuHomePhabricator

Fix a lookup issue in Owners
ClosedPublic

Authored by epriestley on Apr 15 2014, 6:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 9:53 AM
Unknown Object (File)
Fri, May 3, 10:08 AM
Unknown Object (File)
Thu, Apr 25, 3:16 AM
Unknown Object (File)
Thu, Apr 11, 10:53 AM
Unknown Object (File)
Apr 3 2024, 6:06 PM
Unknown Object (File)
Apr 3 2024, 6:06 PM
Unknown Object (File)
Apr 2 2024, 1:27 PM
Unknown Object (File)
Feb 24 2024, 1:51 AM
Subscribers

Details

Summary

Fixes T4477. Sort of winging this but it's probably the right fix?

One error in T4477.

One error via email:

[2014-04-15 17:44:34] ERROR 8: Undefined index: /some_index/ at [/phab_path/phabricator/src/applications/owners/storage/PhabricatorOwnersPackage.php:213]
  #0 PhabricatorOwnersPackage::findLongestPathsPerPackage(Array of size 3 starting with: { 0 => Array of size 3 starting with: { id => 5 } }, Array of size 8 starting with: { / => Array of size 2 starting with: { /some_index/some_file.py => true } }) called at [/phab_path/phabricator/src/applications/owners/storage/PhabricatorOwnersPackage.php:170]
  #1 PhabricatorOwnersPackage::loadPackagesForPaths(Object PhabricatorRepository, Array of size 2 starting with: { 0 => /some_index/some_file.py }) called at [/phab_path/phabricator/src/applications/owners/storage/PhabricatorOwnersPackage.php:119]
...
Test Plan

Will make @zeeg do it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix a lookup issue in Owners.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a subscriber: zeeg.
btrahan edited edge metadata.

makes sense to me

This revision is now accepted and ready to land.Apr 15 2014, 6:10 PM
epriestley updated this revision to Diff 20835.

Closed by commit rP20abf37b88cd (authored by @epriestley).