Page MenuHomePhabricator

Fix a lookup issue in Owners
ClosedPublic

Authored by epriestley on Apr 15 2014, 6:09 PM.
Tags
None
Referenced Files
F18275659: D8779.id20835.diff
Fri, Aug 22, 7:07 PM
F18228659: D8779.diff
Wed, Aug 20, 7:46 AM
F18107205: D8779.diff
Sun, Aug 10, 11:46 PM
F18054810: D8779.id20835.diff
Mon, Aug 4, 6:45 AM
F18036578: D8779.id20835.diff
Sun, Aug 3, 1:59 AM
F17987835: D8779.id20834.diff
Fri, Aug 1, 10:37 PM
F17953284: D8779.id20834.diff
Fri, Aug 1, 2:57 AM
F17941374: D8779.id.diff
Thu, Jul 31, 5:21 AM
Subscribers

Details

Summary

Fixes T4477. Sort of winging this but it's probably the right fix?

One error in T4477.

One error via email:

[2014-04-15 17:44:34] ERROR 8: Undefined index: /some_index/ at [/phab_path/phabricator/src/applications/owners/storage/PhabricatorOwnersPackage.php:213]
  #0 PhabricatorOwnersPackage::findLongestPathsPerPackage(Array of size 3 starting with: { 0 => Array of size 3 starting with: { id => 5 } }, Array of size 8 starting with: { / => Array of size 2 starting with: { /some_index/some_file.py => true } }) called at [/phab_path/phabricator/src/applications/owners/storage/PhabricatorOwnersPackage.php:170]
  #1 PhabricatorOwnersPackage::loadPackagesForPaths(Object PhabricatorRepository, Array of size 2 starting with: { 0 => /some_index/some_file.py }) called at [/phab_path/phabricator/src/applications/owners/storage/PhabricatorOwnersPackage.php:119]
...
Test Plan

Will make @zeeg do it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix a lookup issue in Owners.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a subscriber: zeeg.
btrahan edited edge metadata.

makes sense to me

This revision is now accepted and ready to land.Apr 15 2014, 6:10 PM
epriestley updated this revision to Diff 20835.

Closed by commit rP20abf37b88cd (authored by @epriestley).